fixed memory leak and added TSL workaround for iOS 5.0 #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rkaround for TLS connections for iOS 5.0
fixed memory leak if socket fails connection in secure mode, added worka...
Closed
|
This needs a rebase and there's a bunch of commits which shouldn't have been added. Please re-submit a pull request if this is still an issue. |
|
This solution is not working for wss on IOS 9.1, i'm getting CFNetwork SSLHandshake failed (-9847) error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-renamed the block variable "self" to "webSocket" in several blocks to prevent confusion
-ensured references in blocks to self (and properties of self) properly reference the "webSocket" block variable to prevent retain loops
-added the TSL workaround for iOS 5.0 devices to properly connect on secure connections as described here https://developer.apple.com/library/ios/#technotes/tn2287/_index.html#//apple_ref/doc/uid/DTS40011309