Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mock_callable types #268

Merged
merged 1 commit into from
Nov 12, 2020
Merged

Fix mock_callable types #268

merged 1 commit into from
Nov 12, 2020

Conversation

fornellas
Copy link
Contributor

Fix types for places that generate mypy errors at other projects:

error: Argument 1 to "to_return_value" of "_MockCallableDSL" has incompatible type "StrictMock"; expected "Union[bool, str, int, None]"

@fornellas fornellas added the bug Something isn't working label Nov 12, 2020
@fornellas fornellas merged commit efb4ddb into master Nov 12, 2020
@fornellas fornellas deleted the fix_types branch November 12, 2020 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shish shish shish approved these changes

@deathowl deathowl Awaiting requested review from deathowl

Assignees
No one assigned
Labels
bug Something isn't working mock(_async)_callable mock_constructor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fornellas @shish