Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add minSdkVersion to AndroidManifest.xml #12
Not setting a minSdkVersion causes the Android build system to automatically add the READ_PHONE_STATE permission. (Default value of minSdkVersion and targetSdkVersion is 3)
From and Mainfest.permission docs:
Unfortunately I haven't been able to test this, as building android-jsc gives me a ton of errors, I guess the buildscript has to be adjusted a bit.
We initially saw this permission popping up on our app after adding the react-native dependency.
added a commit
this pull request
Jan 12, 2016
referenced this pull request
Mar 24, 2016
So as I understand it, this fix has been withheld for ten months, because of a concern about the version number needing to match the original JSC version?
Looks like the current version from Sept 2015 is r174650:
Can't you just publish this as r174650.1 and be done with it?