Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
branch: master

Feb 07, 2014

  1. James Pearce

    Update README.rst

    authored February 07, 2014

Sep 13, 2013

  1. Scott MacVicar

    Merge pull request #1 from tobyhughes/master

    Upgraded the libphutil version from v1 to v2
    authored September 12, 2013

Mar 19, 2013

  1. Toby Hughes

    Upgraded the libphutil module from v1 to v2

    authored March 19, 2013

Apr 12, 2012

  1. John Sichi

    Add dummy test plan if none supplied. Once upon a time this was not

    needed, but an update on the server side made it necessary.
    authored April 11, 2012

Mar 15, 2012

  1. [HBASE-5575] Java lint should only report problems for modified lines

    Summary: Making Java linter work treat all messages as warnings, which makes it
    only report issues for modified lines. It would be difficult to reformat all
    HBase code to satisfy the linter, so if a patch does not touch certain lines, we
    should not report problems for those lines.
    
    Test Plan:
    Make some local changes in HBase code with lines longer than 80 characters and
    trailing whitespace, then run arc lint
    
    Reviewers: nspiegelberg, mareksapotafb, jsichi, davidrecordon, nh
    
    Reviewed By: nh
    
    Differential Revision: https://reviews.facebook.net/D2295
    authored March 13, 2012

Dec 22, 2011

  1. Include link back to JIRA in revision summary.

    Summary: Makes it easier to navigate back and forth between JIRA and Phabricator
    UI's.
    
    Test Plan: Run arc diff --jira and verify that JIRA link is included in revision
    summary.
    
    Reviewers: mareksapotafb
    
    Reviewed By: mareksapotafb
    
    CC: cwsteinbach, mareksapotafb
    
    Differential Revision: 981
    authored December 20, 2011

Dec 13, 2011

  1. mareksapota-fb

    Make after commit hook work with other JIRA issue states.

    Reviewers: jsichi
    
    Test plan:
    Commit an issue with status Patch Available, link to resolving the issue should
    have action 741 instead of 5.
    
    Differential Revision: 831
    authored December 13, 2011
  2. mareksapota-fb

    Merge branch 'master' of github.com:facebook/arc-jira

    authored December 12, 2011
  3. mareksapota-fb

    Remove more HTML markup from JIRA summaries

    Test Plan:
    Do `arc diff --jira jira_id` with a JIRA that has lots of HTML formatting, like
    HIVE-2643.
    
    Reviewers: jsichi
    
    Reviewed By: jsichi
    
    CC: jsichi
    
    Differential Revision: 795
    authored December 12, 2011

Dec 09, 2011

  1. mareksapota-fb

    Fix lint for removed files

    Summary: Don't run JavaLintEngine on files that were removed.
    
    Test Plan: Remove a Java file and run arc diff.
    
    Reviewers: jsichi
    
    Reviewed By: jsichi
    
    CC: jsichi
    
    Differential Revision: 681
    authored December 08, 2011

Dec 06, 2011

  1. mareksapota-fb

    Update README to include descriptions of all new functionality

    Test Plan: None
    
    Reviewers: jsichi
    
    Reviewed By: jsichi
    
    CC: jsichi
    
    Differential Revision: 627
    authored December 06, 2011

Nov 17, 2011

  1. mareksapota-fb

    Merge branch 'no_congratulations_on_show'

    authored November 17, 2011
  2. mareksapota-fb

    Don't show url to resolving a JIRA issue on commit --show

    Test Plan: Tried `arc commit --revision 375 --show` and it didn't show the url.
    
    Reviewers: jsichi
    
    Reviewed By: jsichi
    
    CC: jsichi
    
    Differential Revision: 495
    authored November 16, 2011
  3. mareksapota-fb

    Fix getting issue key from JIRA when using HPHP

    Summary:
    Fixed commit workflow extension when using HPHP.  When getting the issue key
    fails Arc-JIRA won't silently ignore it.
    
    Test Plan: Tried `arc commit --revision 375 --show` on localhost and a
    devserver.
    
    Reviewers: jsichi
    
    Reviewed By: jsichi
    
    CC: jsichi
    
    Differential Revision: 489
    authored November 16, 2011
  4. mareksapota-fb

    Add (author via committer) message on `arc commit`

    Test Plan:
    Run `arc commit --show` on some accepted revision of other person, this should
    present you the commit message with (author via committer) on the second line.
    
    Reviewers: jsichi
    
    Reviewed By: jsichi
    
    CC: mareksapotafb, jsichi
    
    Differential Revision: 393
    authored November 10, 2011

Nov 09, 2011

  1. mareksapota-fb

    Add a basic Java lint engine

    Summary:
    The lint engine is very basic, it only checks line length, trailing whitespace,
    etc.
    
    Test Plan:
    Add this linter to Hive .arcconfig, run `arc lint --lintall **/*` and look at
    the beautiful errors=)
    
    Reviewers: jsichi
    
    Reviewed By: jsichi
    
    CC: jsichi
    
    Differential Revision: 339
    authored November 08, 2011

Nov 07, 2011

  1. mareksapota-fb

    Fix workflows that do not require repo api or a conduit.

    Test Plan:
    `arc install-certificate` and other workflows that do not require repository api
    and/or conduit should work properly.
    
    Reviewers: jsichi
    
    Reviewed By: jsichi
    
    CC: jsichi
    
    Differential Revision: 303
    authored November 07, 2011

Nov 04, 2011

  1. mareksapota-fb

    Show link to JIRA resolve issue page after commit.

    Summary: This requires https://secure.phabricator.org/D1078 patch to Arcanist.
    
    Test Plan:
    Commit a revision that was created with `--jira` switch, you should get a direct
    link to resolving that issue.
    
    Reviewers: jsichi
    
    Reviewed By: jsichi
    
    CC: jsichi, mareksapotafb
    
    Differential Revision: 243
    authored November 04, 2011

Nov 02, 2011

  1. mareksapota-fb

    Move diff logic to separate functions so it's easier to extend other …

    …workflows
    
    Test Plan: Arcanist should work same as before the change.
    
    Reviewers: jsichi
    
    Reviewed By: jsichi
    
    CC: jsichi
    
    Differential Revision: 219
    authored November 02, 2011

Oct 31, 2011

  1. mareksapota-fb

    Extend SVN workflow

    Summary: Extend SVN `arc diff` workflow.
    
    Test Plan:
    Run `arc diff` or `arc diff --jira ID` in SVN repo.  It should allow ask you if
    you want to connect created diff to an existing revision and if you provided
    `--jira` switch it should allow you to create a new revision and fill in fields
    by pulling info from JIRA.
    
    Reviewers: jsichi
    
    Reviewed By: jsichi
    
    CC: jsichi
    
    Differential Revision: 123
    authored October 31, 2011

Oct 27, 2011

  1. mareksapota-fb

    Allow only issue number as parameter to --jira

    Allow user to set the project in .arcconfig and only give issue numbers as
    parameters to arc diff --jira.  Improved error messages when user gives a wrong
    JIRA ID.
    authored October 27, 2011
  2. mareksapota-fb

    Change commit title to make both JIRA and Hudson happy

    Test Plan: Commit title should be like `HIVE-123 [jira] some text`
    
    Reviewers: jsichi
    
    Reviewed By: jsichi
    
    CC: jsichi
    
    Differential Revision: 81
    authored October 26, 2011
  3. mareksapota-fb

    Fill in the README file.

    authored October 26, 2011

Oct 26, 2011

  1. mareksapota-fb

    Prevent duplicate emails to JIRA, get user info from Phabricator

    JIRA user is put into Reviewers field instead of CC to prevent duplicate
    comments in JIRA.  User names are pulled from Phabricator instead of using regex
    on raw commit message.
    authored October 26, 2011

Oct 25, 2011

  1. mareksapota-fb

    Add the library code

    authored October 25, 2011
  2. mareksapota-fb

    Initial commit

    authored October 25, 2011
Something went wrong with that request. Please try again.