Skip to content
This repository
tag: conduit-5

May 21, 2012

  1. Evan Priestley

    Bump Conduit client version

    Summary:
    Several related changes:
    
      - Add a "--conduit-version" flag, so you can actually diff conduit version bumps. Otherwise, the server rejects you.
      - Make "arc upgrade" upgrade both libphutil and arcanist, not just arcanist.
      - Bump the version number to 5. See D2527.
    
    Test Plan:
      - Ran "arc upgrade".
      - Ran "arc diff". Got told there was a version issue.
      - Ran "arc diff --conduit-version=4" to create this diff.
    
    Reviewers: indiefan, nh, vrana, btrahan, jungejason, Makinde
    
    Reviewed By: vrana
    
    CC: aran
    
    Differential Revision: https://secure.phabricator.com/D2528
    authored

May 20, 2012

  1. Evan Priestley

    Dispatch a "diff.willBuildMessage" event from Arcanist

    Summary:
    Hive has custom integration which relies on prefilling a bunch of information from JIRA. This is currently broken and accomplished in a roundabout way. Instead, add an event that the integration can listen for. See next diff.
    
    @Girish, I guess you're official Phabricator/Hive support now?
    
    Test Plan: Ran the Hive/JIRA workflows in Git and SVN, see next diff.
    
    Reviewers: Girish, btrahan, ashutoshc
    
    Reviewed By: btrahan
    
    CC: aran
    
    Maniphest Tasks: T1206
    
    Differential Revision: https://secure.phabricator.com/D2449
    authored

May 19, 2012

  1. Say until when the reviewers are away

    Test Plan: `arc diff` with reviewers away.
    
    Reviewers: btrahan, epriestley
    
    Reviewed By: epriestley
    
    CC: aran, epriestley
    
    Differential Revision: https://secure.phabricator.com/D2496
    authored

May 18, 2012

  1. Warn user about specifying reviewers that are away

    Summary:
    There are different options how to implement this:
    We can also generate the warning in `validateField()` and handle it in all callsites.
    This is sufficient for me and simple enough.
    
    Test Plan: `arc diff` revision with reviewer away/not away.
    
    Reviewers: btrahan, jungejason
    
    Reviewed By: jungejason
    
    CC: epriestley, aran
    
    Differential Revision: https://secure.phabricator.com/D2493
    authored

May 17, 2012

  1. Evan Priestley

    Merge pull request #28 from phleet/hg-multiple-heads

    Make arc diff work with multiple heads in hg
    authored
  2. Jamie Wong

    Make arc diff work with multiple heads in hg

    authored
  3. Evan Priestley

    Merge pull request #27 from phleet/hg-bookmark

    Make arc diff not crash on hg bookmarks
    authored

May 16, 2012

  1. Jamie Wong

    Make arc diff not crash on hg bookmarks

    authored

May 12, 2012

  1. Nick Harper

    Provide user-friendly error in arc diff --update

    Summary:
    If you forget to provide an argument for --update and have another argument
    following it (e.g. HEAD^), we should provide a nice error message instead
    of passing that argument through to a conduit call and then printing the
    conduit error.
    
    Test Plan: ran 'arc diff --update HEAD^' and got a nice error message
    
    Reviewers: epriestley, jungejason, vrana
    
    Reviewed By: epriestley
    
    CC: aran, Koolvin
    
    Differential Revision: https://secure.phabricator.com/D2468
    authored

May 11, 2012

  1. Evan Priestley

    Fix "local commits" for Git and Mercurial to align with user expectat…

    …ions, and fix a parsing bug
    
    Summary:
      - "git log" still includes "\n", so we're currently generating nonsense hashes like "\nabd9879bab86ad78ab...".
      - Correct the log range we use in Git. See comment. When users perform merges, their expectations about what the "included commits" and what the included changes are are different. Represent them with two different ranges.
      - Same deal for Mercurial
    
    Test Plan: Ran "arc which" in various contexts.
    
    Reviewers: btrahan, aurelijus, Makinde
    
    Reviewed By: Makinde
    
    CC: aran, nh, jungejason
    
    Maniphest Tasks: T873
    
    Differential Revision: https://secure.phabricator.com/D2460
    authored
  2. Evan Priestley

    Make "arc which" really really really verbose

    Summary: Provide far more information about what "arc diff" intends to do.
    
    Test Plan: Ran "arc which" in a variety of circumstances.
    
    Reviewers: btrahan, Makinde
    
    Reviewed By: Makinde
    
    CC: aran
    
    Maniphest Tasks: T1183
    
    Differential Revision: https://secure.phabricator.com/D2454
    authored
  3. Nick Harper

    Remove arc export's dependency on a working copy when using --diff

    Summary:
    When getting an encoding, we should query the server for the encoding of the
    project that we're exporting from, not the project that we're running arc in
    (arc might not be in a working copy).
    
    Test Plan: ran arc export with --diff and didn't get a workflow exception
    
    Reviewers: epriestley, jungejason, vrana, davidreuss
    
    Reviewed By: jungejason
    
    CC: aran, Koolvin
    
    Differential Revision: https://secure.phabricator.com/D2455
    authored

May 10, 2012

  1. Evan Priestley

    arc land: add --delete-remote, raise an error for landing a branch on…

    …to itself
    
    Summary:
      - Allow users to delete the remote copy of a feature branch as well as the local one, for workflows that push feature branches. We test if the remote exists before trying to delete it.
      - Raise a better warning when you misuse "arc land".
      - I also wrote some documentation about this, see next diff.
    
    Test Plan:
      - Tried to land a branch onto itself.
      - Ran "arc land --delete-remote" on feature branches with and without remote feature branches.
    
    Reviewers: aurelijus, btrahan
    
    Reviewed By: aurelijus
    
    CC: aran
    
    Maniphest Tasks: T1204
    
    Differential Revision: https://secure.phabricator.com/D2445
    authored
  2. Evan Priestley

    Fix 'rev' index error for Mercurial

    Summary: I renamed this in D2437 for greater consistency with everything else, but missed this use of the old key.
    
    Test Plan: idk lmk?
    
    Reviewers: Makinde
    
    Reviewed By: Makinde
    
    CC: aran
    
    Differential Revision: https://secure.phabricator.com/D2452
    authored

May 09, 2012

  1. Evan Priestley

    Ship complete commit messages to Phabricator from Arcanist

    Summary: Currently, we ship only the summary, but we need to ship the whole thing for T1189.
    
    Test Plan: Added var_dump() + die, ran in git and hg working copies, verified 'message' included the whole message.
    
    Reviewers: csilvers, btrahan, Makinde
    
    Reviewed By: csilvers
    
    CC: aran
    
    Maniphest Tasks: T1189
    
    Differential Revision: https://secure.phabricator.com/D2437
    authored
  2. Evan Priestley

    "arc upgrade", to automatically upgrade arc (client changes)

    Summary:
      - Try to limit the pain of //future// version bumps by making arc self-updating.
      - When the server needs a newer version, prompt the user to update.
      - (We need them to reissue their command because we may already have loaded classes which have changed in the update.)
      - Make the message sound exciting!
    
    Test Plan: Artifically bumped server forward, ran "arc list", got to upgrade!
    
    Reviewers: Makinde, nh, jungejason, btrahan
    
    Reviewed By: nh
    
    CC: aran
    
    Differential Revision: https://secure.phabricator.com/D2435
    authored
  3. Nick Harper

    Catch ArcanistUsageException when getting git parent log info

    Summary:
    ArcanistDiffWorkflow::getGitParentLogInfo() calls
    ArcanistDifferentialCommitMessage::newFromRawCorpus() which may throw a
    ArcanistUsageException if the parent commit message is malformed (specifically,
    a bad "Differential Revision:" line); this should not stop arc diff.
    
    Test Plan: successfully ran arc diff where the parent commit message was malformed.
    
    Reviewers: epriestley, jungejason
    
    Reviewed By: epriestley
    
    CC: aran, Koolvin
    
    Differential Revision: https://secure.phabricator.com/D2434
    authored

May 08, 2012

  1. Nick Harper

    Allow --verbatim and -m in arc diff

    Summary:
    There's no reason these should be exclusive: -m is used only on update for the
    update message, and --verbatim doesn't affect the udpate message. It's also
    useful to allow both of these, if say I want to update my test plan by editing
    my git commit message and also provide a message for the update from the
    command line.
    
    Test Plan:
    ran arc diff with --verbatim and -m and saw my message from -m was used, as
    well as my updates in the commit message went through.
    
    Reviewers: jungejason, epriestley, vrana
    
    Reviewed By: epriestley
    
    CC: aran, Koolvin
    
    Differential Revision: https://secure.phabricator.com/D2426
    authored

May 07, 2012

  1. Evan Priestley

    Allow 'arc' to run without '.arcconfig'

    Summary:
    This is mostly an onboarding thing, but also allows "arc upload", "arc download", and "arc paste" to work anywhere on the system.
    
      - Try to read the Phabricator install URI from arc global config if we can't find ".arcconfig".
      - Build a WorkingCopy anyway if we can't find ".arcconfig", as long as we can find ".svn", ".git", or ".hg".
      - Make all the workflows handle "no project ID" at least somewhat gracefully.
    
    Test Plan:
      - Ran "arc diff" in .arcconfig-less Mercurial, Git, and Subversion working copies.
      - Ran "arc upload" and "arc download" from my desktop.
      - Ran "arc paste" from somewhere random.
      - Cleared my config and hit the error, got useful instructions.
    
    Reviewers: btrahan, csilvers
    
    Reviewed By: csilvers
    
    CC: aran
    
    Differential Revision: https://secure.phabricator.com/D2424
    authored
  2. Evan Priestley

    Provide more context in "arc diff" messages in Git

    Summary: These are the unambiguously-good changes from D2388. Show commits included in a revision in the editor in "arc diff".
    
    Test Plan: Ran "arc diff", saw which commits were being included.
    
    Reviewers: nh, jungejason, vrana, btrahan
    
    Reviewed By: btrahan
    
    CC: aran
    
    Maniphest Tasks: T1183
    
    Differential Revision: https://secure.phabricator.com/D2406
    authored
  3. Nick Harper

    Always use git.default-relative-commit, if present

    Summary:
    Always use the value in git.default-relative-commit when getting the relative
    commit in git.
    
    Test Plan:
    Ran arc diff in a repo with git.default-relative-commit set to HEAD^ on a
    branch tracking a remote (that is different from HEAD^), and checked that
    the diff against HEAD^, not the remote, was published.
    
    Reviewers: jungejason, epriestley, vrana
    
    Reviewed By: epriestley
    
    CC: aran, Koolvin
    
    Differential Revision: https://secure.phabricator.com/D2409
    authored
  4. Evan Priestley

    With `--verbatim`, update some fields automatically when updating rev…

    …isions
    
    Summary:
    Essentially D2391, but with, uh, more comments?
    
      - I forgot that we already implemented shouldOverwriteWhenCommitMessageIsEdited(). This patch already behaves nearly correctly.
      - Requires changes in D2412.
      - Use `'edit' => 'edit'`, which does the same thing as `'edit' => true`, but is more correct after the "edit" / "create" split.
      - Under "--verbatim", always get the message "from the user", which means "from the working copy" because verbtatim disables the editor part.
    
    Test Plan:
          - Created and updated revisions with `arc diff`.
          - Created and updated revisions with `arc diff --verbatim`.
          - Updated revisions with `arc diff --edit`.
    
    Reviewers: jungejason, btrahan
    
    Reviewed By: jungejason
    
    CC: vrana, aran
    
    Differential Revision: https://secure.phabricator.com/D2411
    authored
  5. Evan Priestley

    Finish "Committed" -> "Closed" changes

    Summary:
    Clean up the remaining odds-and-ends here -- move to "differential.close", get rid of the old constant, etc.
    
    I'll wait a week or two to land this since "differential.close" just landed and all the other stuff is trivial.
    
    Test Plan: Grepped for "committed".
    
    Reviewers: btrahan, vrana, Makinde
    
    Reviewed By: btrahan
    
    CC: aran
    
    Maniphest Tasks: T909, T1182
    
    Differential Revision: https://secure.phabricator.com/D2309
    authored
  6. Evan Priestley

    Add "arc get-config" and "arc set-config" for managing ~/.arcrc values

    Summary:
    The major thing I want to do here is allow you to set a default Phabricator URI, so we can make "arc paste", and "arc upload", "arc download" work anywhere.
    
    We can also relax the .arcconfig requirements (request from @csilvers).
    
    Test Plan:
    Get/set some values?
    
    iiam
    
    Reviewers: btrahan, vrana, jungejason
    
    Reviewed By: btrahan
    
    CC: aran
    
    Differential Revision: https://secure.phabricator.com/D2400
    authored
  7. Evan Priestley

    Remove git commit template from Arcanist

    Summary: Out of date an no longer referenced.
    
    Test Plan: Grepped for references.
    
    Reviewers: btrahan, vrana
    
    Reviewed By: btrahan
    
    CC: aran
    
    Differential Revision: https://secure.phabricator.com/D2387
    authored
  8. Evan Priestley

    Explicitly check for cURL in "arc"

    Summary: We do this in Windows, but it's not available by default in Ubuntu
    
    Test Plan: Ran "arc" after faking the function name, got a reasonable error.
    
    Reviewers: btrahan, jungejason
    
    Reviewed By: btrahan
    
    CC: aran
    
    Differential Revision: https://secure.phabricator.com/D2404
    authored

May 04, 2012

  1. Evan Priestley

    Clean up some "arc" edge cases in Mercurial

    Summary:
      - We no longer need color options since we fake our way through parsing ANSI colorized diffs and use HGPLAIN (on Windows, too!). Drop 'em.
      - In the case where you have nothing outgoing, we don't cache the relative commit and thus run "hg outgoing" too many times, which is fairly slow (even if you have nothing outgoing). Cache it.
    
    Test Plan: Ran "arc diff --trace" in a mercurial working copy with nothing outgoing; verified we run "hg outgoing" only once.
    
    Reviewers: Makinde, csilvers, btrahan
    
    Reviewed By: Makinde
    
    CC: aran
    
    Differential Revision: https://secure.phabricator.com/D2399
    authored
  2. Document first line behavior in update message

    Test Plan: (This diff)
    
    Reviewers: epriestley, jungejason
    
    Reviewed By: jungejason
    
    CC: aran, Koolvin
    
    Differential Revision: https://secure.phabricator.com/D2389
    authored
  3. Don't ask user to use saved message in `arc diff --verbatim`

    Test Plan:
    Cancel `arc diff`.
    Verify that the message is created.
    Run `arc diff --verbatim` and see no reuse message question.
    
    Reviewers: epriestley
    
    Reviewed By: epriestley
    
    CC: aran, Koolvin
    
    Differential Revision: https://secure.phabricator.com/D2390
    authored
  4. Warn before parse errors in `arc diff --verbatim`

    Summary: With `--verbatim` flag, notes created from parse errors are never displayed to user resulting in blank fields.
    
    Test Plan:
    - `arc diff --verbatim` with invalid Cc
    - `arc diff --verbatim` with all fields correct
    
    Reviewers: epriestley, jungejason
    
    Reviewed By: epriestley
    
    CC: aran, Koolvin
    
    Differential Revision: https://secure.phabricator.com/D2395
    authored

May 02, 2012

  1. Marke Hallowell

    Updated arc land workflow to use temp file approach for messages to a…

    …void newline escaping issue in windows.
    
    Test Plan: Ran arc land locally with both the mutable default option and with the --merge flag to ensure that messages are set properly.
    
    Reviewers: epriestley
    
    Reviewed By: epriestley
    
    CC: aran, Koolvin
    
    Differential Revision: https://secure.phabricator.com/D2372
    authored epriestley committed
  2. Evan Priestley

    Fix "HGPLAIN" environmental variable in Windows

    Summary: In Windows, you can't use `X=y cmd` syntax to set variables. Use "set X=y & cmd" instead.
    
    Test Plan:
      - Ran "arc diff" in a Mercurial repo in Windows, created D2367.
      - Verified this does //not// cause 'HGPLAIN' to be set in the outer shell (where you type "arc diff").
    
    Reviewers: Makinde, tido, indiefan, btrahan
    
    Reviewed By: tido
    
    CC: aran
    
    Maniphest Tasks: T1179
    
    Differential Revision: https://secure.phabricator.com/D2368
    authored
  3. Marke Hallowell

    Using a temp file for git commit --amend instead of passing multi-lin…

    …e message to the shell. Avoids escaping issue on windows.
    
    Test Plan: Run arc diff locally, verify via git log that the commit is amended afterwards (using the mutable history paradigm)
    
    Reviewers: epriestley
    
    Reviewed By: epriestley
    
    CC: aran, Koolvin
    
    Differential Revision: https://secure.phabricator.com/D2369
    authored epriestley committed
  4. edwardspeyer

    Help the analyzer find phutil_is_hiphop_runtime

    Summary:
    rPHUf9ba25d188c1dcf39e4454b2c6bb058e0beeaa3e adds
    global function phutil_is_hiphop_runtime() to
    __phutil_library_init__.php.  This diff helps lint files that call that
    function.
    
    Test Plan: Lint D2365.
    
    Reviewers: epriestley
    
    Reviewed By: epriestley
    
    CC: aran, Koolvin
    
    Differential Revision: https://secure.phabricator.com/D2366

May 01, 2012

  1. Evan Priestley

    Don't check working copy status for "arc commit --show"

    Summary:
    We do unnecessary working copy checks under "--show", even though the working copy isn't relevant.
    
    Also, 'sourcePath' may not be set (e.g., "arc commit --show --revision X" where X is some "--only" revision).
    
    Test Plan: Ran "arc commit --show --revision 1" against some test data, got clean output.
    
    Reviewers: vrana, btrahan, jungejason
    
    Reviewed By: vrana
    
    CC: aran
    
    Differential Revision: https://secure.phabricator.com/D2353
    authored
Something went wrong with that request. Please try again.