Permalink
3 comments
on commit
sign in to comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Merge certain entitlement keys that should be included
Summary: Some entitlements were incorrectly excluded from being merged when signing a iOS bundle. This would manifest itself in the edge case where we added one of these entitlements to an app, but Buck still chose an old provisioning profile without the newly-added entitlements. This caused Buck-built `.ipa`s to be uninstallable on devices (or not able to be submitted to the App Store) if their profile didn't have the right entitlements. Test Plan: Build apps with those entitlements and submit them to App Store. Reviewed By: dinhviethoa fbshipit-source-id: 5444f1d
- Loading branch information
Showing
with
0 additions
and 2 deletions.
This comment has been minimized.
Hi,
Why did you remove
com.apple.developer.associated-domains
from the backlisted keys ?This key should not go from the provisioning profile (where it is always set to
*
AFAIK) to the resulting Entitlements : the*
value is considered as invalid by Apple.This comment has been minimized.
For apps that support universal links, we do need that key in the entitlements. https://developer.apple.com/library/content/documentation/General/Conceptual/AppSearch/UniversalLinks.html#//apple_ref/doc/uid/TP40016308-CH12-SW2
In those cases, the value would not be '*'.
This comment has been minimized.
My understanding was that these excluded keys were removed from the Provisioning Profile (where associated domains are always
*
), not from the resulting Entitlements (thus allowing the actual values from the App Entitlements to be used instead).