Permalink
Commits on Jul 21, 2018
  1. Enable DxStep to read dirs with D8

    asp2insp authored and facebook-github-bot committed Jul 20, 2018
    Summary:
    DxStep was not previously recursing when passing directories to D8 tool. This meant that
    multidex canary classes (which are the only ones currently passed as dirs during dex merge) were
    not included in the app, breaking multidex support.
    
    Reviewed By: julian-krzeminski
    
    fbshipit-source-id: adb07a387c
Commits on Jul 20, 2018
  1. Remove first party dependency sources

    math4tots authored and facebook-github-bot committed Jul 20, 2018
    Summary:
    This option is no longer needed, and seems to have had little use.
    To help keep the codebase healthy, I'm removing this feature.
    
    This doesn't revert everything from the older commit (e.g. parsing source root finder), but should remove anything directly related to this feature not used by any other feature.
    
    Reviewed By: styurin
    
    fbshipit-source-id: dff86c6105
  2. Allow DescriptionCache to keep configuration rule descriptions

    styurin authored and facebook-github-bot committed Jul 20, 2018
    Summary: Generalize `DescriptionCache` to support configuration rules.
    
    Reviewed By: bobyangyf
    
    fbshipit-source-id: 0f67b5318b
  3. Rename BuildRuleType to RuleType

    styurin authored and facebook-github-bot committed Jul 20, 2018
    Summary: We now have configuration and build rules. `BuildRuleType` doesn't have anything related to build rules so it can be renamed.
    
    Reviewed By: bobyangyf
    
    fbshipit-source-id: e25f88691d
  4. Introduce a common interface shared between configuration and build r…

    styurin authored and facebook-github-bot committed Jul 20, 2018
    …ule descriptions
    
    Summary: Configuration and build rules need to share some base that would allow us to change parsing logic to use that common base instead of build rule descriptions.
    
    Reviewed By: ttsugriy
    
    fbshipit-source-id: 7fb2d61a03
  5. Add a version code to AndroidManifest.xml

    Yibo Liu authored and facebook-github-bot committed Jul 20, 2018
    Summary: Add a version code to AndroidManifest.xml
    
    Reviewed By: styurin
    
    fbshipit-source-id: e75779baf3
  6. Override methods to place files in base module

    Yibo Liu authored and facebook-github-bot committed Jul 20, 2018
    Summary: Override methods in ApkBuilder to place files in lib and assets into base module
    
    Reviewed By: styurin
    
    fbshipit-source-id: 247bf91580
  7. add more logging in interceptor

    aiked authored and facebook-github-bot committed Jul 20, 2018
    Summary: add logging interceptors in the ping clients.
    
    Reviewed By: shivanker
    
    fbshipit-source-id: 66c676b8a6
  8. Fix futures-chain for async upload of local file changes.

    shivanker authored and facebook-github-bot committed Jul 20, 2018
    Summary: `transform` with a function that returns a future means you only wait for the creation of the second future object, not its completion. `transformAsync` chains these futures in the desired way here.
    
    Reviewed By: aiked
    
    fbshipit-source-id: 173a54c045
  9. Add missing EasyMock verifications.

    shivanker authored and facebook-github-bot committed Jul 20, 2018
    Summary: Not really required because we're capturing the input and inspecting it manually, but having verification calls makes the test more readable and trustworthy.
    
    Reviewed By: aiked
    
    fbshipit-source-id: 32eb4b2479
  10. Convert XCode project generator to a module

    styurin authored and facebook-github-bot committed Jul 20, 2018
    Reviewed By: sbalabanov
    
    fbshipit-source-id: 5c900ab9e5
  11. Improve space complexity of Levenstein distance computation.

    ttsugriy authored and facebook-github-bot committed Jul 20, 2018
    Summary:
    It's not necessary to store an entire table with previuos results -
    storing a previous row is enough.
    
    This also slightly improves computation perf for no-match case by factoring
    out addition.
    
    Reviewed By: bobyangyf
    
    fbshipit-source-id: 1bdfcf694f
  12. Fix non-thread-safe usage of DateFormat.

    ttsugriy authored and facebook-github-bot committed Jul 20, 2018
    Summary:
    https://docs.oracle.com/javase/8/docs/api/java/text/SimpleDateFormat.html
    ```
    Synchronization
    Date formats are not synchronized. It is recommended to create separate format instances for each thread. If multiple threads access a format concurrently, it must be synchronized externally.
    ```
    
    Reviewed By: sbalabanov
    
    fbshipit-source-id: 92c0746462
  13. Include a list of possible spelling suggestions in invalid cell error…

    ttsugriy authored and facebook-github-bot committed Jul 20, 2018
    … message.
    
    Summary: Spelling suggestions may reveal a typo and result in better user experience.
    
    Reviewed By: styurin
    
    fbshipit-source-id: 0d09eec297
  14. Admonish users to have their GitHub creds configured and in the agent

    carljparker authored and facebook-github-bot committed Jul 19, 2018
    Summary:
    - Let users know that in order to publish, they'll need to have their GitHub creds configured.
    
    - Edit the comments in the script as the script now automatically runs `soyweb-prod.sh`.
    
    Reviewed By: philipjameson
    
    fbshipit-source-id: 13b21130e5
Commits on Jul 19, 2018
  1. Refactor TargetSpecResolver.resolveTargetSpecs to reduce complexity

    styurin authored and facebook-github-bot committed Jul 19, 2018
    Summary: Splitting one gigantic method into multiple to facilitate with understanding of the high level logic.
    
    Reviewed By: ttsugriy
    
    fbshipit-source-id: dc6c48b8a7
  2. Move model/AbstractImmutableBuildTarget to core/model/impl

    styurin authored and facebook-github-bot committed Jul 19, 2018
    Reviewed By: ttsugriy
    
    fbshipit-source-id: 367e95b174
  3. Fix sketchy string comparisons.

    ttsugriy authored and facebook-github-bot committed Jul 19, 2018
    Summary:
    Only string references should be checked using `==` operator.
    Content comparison should be done using `equals` method.
    
    Reviewed By: styurin
    
    fbshipit-source-id: 6ec2431504
  4. Move spelling suggestions to MoreStrings.

    ttsugriy authored and facebook-github-bot committed Jul 19, 2018
    Summary:
    This will make its reuse simpler.
    
    Having a separate class for this may be a better option, but since
    Levenstein distance computation lives in `MoreStrings`, it may be
    easier to discover.
    
    Reviewed By: styurin
    
    fbshipit-source-id: 5b352975b5
  5. Ensure Stampede infra errors are printed to console at end of build

    alisdair04 authored and facebook-github-bot committed Jul 19, 2018
    Summary: All Stampede infra errors (e.g. failed to upload target graph) are now clearly logged to the console at the end of the build.
    
    Reviewed By: shivanker
    
    fbshipit-source-id: 2b9c21ee43
  6. Add config_setting rule

    styurin authored and facebook-github-bot committed Jul 19, 2018
    Summary: This change introduces `config_setting` configuration rule that provides `Selectable` which mean it can be used together with `select` statements.
    
    Reviewed By: cjhopman
    
    fbshipit-source-id: 4acf968406
  7. Add output of prebuilt_jar as class root

    asp2insp authored and facebook-github-bot committed Jul 19, 2018
    Summary:
    Given the following scenario:
    
    ```
    genrule(
      name = 'make_jar',
      cmd = '...'
      out = 'my.jar',
    )
    
    prebuilt_jar(
      name = 'my.jar',
      binary_jar = ':make_jar',
    )
    ```
    
    the IJ generated project will point to the output of the genrule. But `prebuilt_jar` will copy the input jar when built, thus producing a cacheable output. So if you get a cache hit on the `prebuilt_jar`, then `buck` will never populate the output location of the `genrule` and now the library iml for IJ points to the wrong location. This diff fixes this by adding both the input and the output paths for a `prebuilt_jar` to the IJ project's library iml.
    
    Reviewed By: styurin
    
    fbshipit-source-id: de223440d6
  8. Give code blocks--including those that use prettyprint--the same bord…

    carljparker authored and facebook-github-bot committed Jul 19, 2018
    …er as inline code
    
    Summary: Override `pre.prettyprint` from `google-code-prettify/prettify.css` so that our non-code styling (borders, margins, padding, etc) is consistent across inline code, prettyfried blocks, and non-prettyfried blocks.
    
    Reviewed By: ttsugriy
    
    fbshipit-source-id: d2bc23653e
  9. shared-interface files: wipe program headers before and after compact…

    Steve O'Brien authored and facebook-github-bot committed Jul 19, 2018
    …ing sections
    
    Summary: objcopy aborts when there are sections moved around within segments and don't align properly.  Deal with this by discarding segments (program headers) in the scratch file, *and* in the final shared interface file.
    
    Reviewed By: andrewjcg
    
    fbshipit-source-id: f31ccff4e6
  10. add more logging on connection failure

    aiked authored and facebook-github-bot committed Jul 19, 2018
    Summary: This adds an interceptor for the frontend requests that will log the remote address of the failed request.
    
    Reviewed By: shivanker
    
    fbshipit-source-id: 73b848eae8
  11. Add gray borders around code-styled text

    carljparker authored and facebook-github-bot committed Jul 19, 2018
    Summary:
    Add a gray border around code-styled text in order to make it easier to visually distinguish code inside running text.
    
    This is a similar style to that used on Slack. GitHub and Bazel do not use this technique. However, they //shade// their inline code dark-gray against a white background whereas we shade lighter against a darker background, which doesn't seem to produce as much contrast.
    
    Reviewed By: styurin
    
    fbshipit-source-id: 458b8696e8
  12. Modify the GenerateBundleConfigStep and its implementation

    Yibo Liu authored and facebook-github-bot committed Jul 18, 2018
    Summary:
    Modify the GenerateBundleConfigStep, integrate it into AndroidBinaryBuildable and AabBuilderStep;
    integrate its test into AndroidAppBundleIntegrationTest
    
    Reviewed By: styurin
    
    fbshipit-source-id: c45d163bcb
  13. Correct the way NativeLib are targeted

    Yibo Liu authored and facebook-github-bot committed Jul 18, 2018
    Summary: Iterate through the subdirectories under lib/ and get NativeLib targeted
    
    Reviewed By: styurin
    
    fbshipit-source-id: 9c65c0a22c
  14. Get Abi of Assets targeted

    Yibo Liu authored and facebook-github-bot committed Jul 18, 2018
    Summary: Explore the Assets subdirectory and extract information needed by abi targeting
    
    Reviewed By: styurin
    
    fbshipit-source-id: 6decbc9395
  15. Move BuildableContext related test files from rules to buildable.cont…

    bobyangyf authored and facebook-github-bot committed Jul 18, 2018
    …ext package
    
    Reviewed By: styurin
    
    fbshipit-source-id: 3359693aca
  16. Move BuildContext related test files from rules to build.context package

    bobyangyf authored and facebook-github-bot committed Jul 18, 2018
    Reviewed By: styurin
    
    fbshipit-source-id: 65c403caff
  17. Move SourcePath related test files from rules to sourcepath package

    bobyangyf authored and facebook-github-bot committed Jul 18, 2018
    Summary: Cleaning up the test dir following moves
    
    Reviewed By: styurin
    
    fbshipit-source-id: a3d40ff84e
Commits on Jul 18, 2018
  1. Remove extra logging used for debugging missing console prints

    bobyangyf authored and facebook-github-bot committed Jul 17, 2018
    Summary:
    These were additional logging used to debug missing console prints.
    The issue is now fixed so we no longer need this.
    
    Reviewed By: styurin
    
    fbshipit-source-id: aec1ed6075
  2. Fix leaked file stream handle(s) in Buckd.

    Lubomir Litchev authored and facebook-github-bot committed Jul 18, 2018
    Summary:
    On Windows non closed file handles can cause failure to delete files.
    The offlineScrubLogger is leaking handles is sendStoredLogs.
    This change makes sure the opened logFileStream is always closed.
    
    Reviewed By: ttsugriy
    
    fbshipit-source-id: a574d87768
  3. Exclude IntelliJ project testdata from IntelliJ project

    styurin authored and facebook-github-bot committed Jul 18, 2018
    Reviewed By: bobyangyf
    
    fbshipit-source-id: 14e1274724