Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Jars built using `JarBuilder` do not mark directories properly #1790
Steps to reproduce (in Buck's own source):
The directory is not marked as a directory in the zip entry extended attributes, and is not marked as executable, meaning that if the user unpacks the directory they won't be able to
Why should it have the unix attribute? I do not believe Jar specification requires that.
This can potentially break other scenarios. Each ZIP implementation may read this field and act accordingly, for example, refuse to decompress.
Java itself detects that entry is a directory only by looking to a trailing slash.