Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows doesn't support `inplace` packaging in `python_binary`s #2161

Open
scottrice opened this issue Jan 15, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@scottrice
Copy link
Member

commented Jan 15, 2019

Setting

[python]
package_style = inplace

in your .buckconfig triggers the following message:

cannot build in-place python binaries for Windows (default)

This was added in 0f1c0d8 (a commit from 4 years ago) when IIRC Buck actually didn't support symlinks on Windows. As far as I can tell, we do now. Setting up Buck on Windows requires an "Enable Symlinks" step, and there are many other rules which do work on Windows that use symlinks (unless they use some strategy I'm not familiar with).

It seems like we should be able to support inplace binaries on Windows machines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.