Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Exopackage with guava #385
I recently tried to add exopackage support to my project, but I'm getting the following error when trying to add guava as a dependency:
It seems the following diff fixes the error and the application works just fine, but I'm not sure it's the right thing to do to just change the limit.
diff --git a/src/com/facebook/buck/android/AndroidBinaryDescription.java b/src/com/facebook/buck/android/AndroidBinaryDescription.java index f892555..0668b80 100644 --- a/src/com/facebook/buck/android/AndroidBinaryDescription.java +++ b/src/com/facebook/buck/android/AndroidBinaryDescription.java @@ -73,7 +73,7 @@ public class AndroidBinaryDescription * By default, assume we have 5MB of linear alloc, * 1MB of which is taken up by the framework, so that leaves 4MB. */ - private static final long DEFAULT_LINEAR_ALLOC_HARD_LIMIT = 4 * 1024 * 1024; + private static final long DEFAULT_LINEAR_ALLOC_HARD_LIMIT = 8 * 1024 * 1024; private static final MacroHandler MACRO_HANDLER = new MacroHandler(
Ah yeah, thanks for clarifying! A little digging shows you were right about Gingerbread, found this article by @dreiss: https://www.facebook.com/notes/facebook-engineering/under-the-hood-dalvik-patch-for-facebook-for-android/10151345597798920 ;)
Digging a little further, I found the