New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Buck to run without Android SDK #7

Closed
spearce opened this Issue Apr 29, 2013 · 4 comments

Comments

Projects
None yet
2 participants
@spearce
Contributor

spearce commented Apr 29, 2013

Add a new option to .buckconfig that indicates the project does not need the Android SDK. Disabling the Android SDK check allows Buck to run for normal Java projects that only need java_library(), java_binary(), and prebuilt_jar().

@bolinfest

This comment has been minimized.

Show comment
Hide comment
@bolinfest

bolinfest Apr 29, 2013

Contributor

Thanks for filing: this is definitely an oversight on our part. Buck is meant to be able to support "pure Java" projects, as well as Android projects.

Contributor

bolinfest commented Apr 29, 2013

Thanks for filing: this is definitely an oversight on our part. Buck is meant to be able to support "pure Java" projects, as well as Android projects.

@ghost ghost assigned bolinfest Apr 29, 2013

@spearce

This comment has been minimized.

Show comment
Hide comment
@spearce

spearce May 1, 2013

Contributor

If you are interested in looking at a real world pure Java project's usage of Buck, see https://gerrit.googlesource.com/gerrit/+/57a4d597cd1111ebabf9bbf495ecd45324e7acdd as it contains a complete, non-trivial "pure Java" project build system alongside of the existing Maven build.

I unfortunately had to use 22 genrules() to provide a number of hacks for features missing from Buck. The worst hack of all was committing local.properties to work around the Android SDK. :-)

Contributor

spearce commented May 1, 2013

If you are interested in looking at a real world pure Java project's usage of Buck, see https://gerrit.googlesource.com/gerrit/+/57a4d597cd1111ebabf9bbf495ecd45324e7acdd as it contains a complete, non-trivial "pure Java" project build system alongside of the existing Maven build.

I unfortunately had to use 22 genrules() to provide a number of hacks for features missing from Buck. The worst hack of all was committing local.properties to work around the Android SDK. :-)

@bolinfest

This comment has been minimized.

Show comment
Hide comment
@bolinfest

bolinfest May 1, 2013

Contributor

I have a fix for this internally, but I'm waiting for a code review :(

On Wed, May 1, 2013 at 10:02 AM, Shawn O. Pearce
notifications@github.comwrote:

If you are interested in looking at a real world pure Java project's usage
of Buck, see
https://gerrit.googlesource.com/gerrit/+/57a4d597cd1111ebabf9bbf495ecd45324e7acddas it contains a complete, non-trivial "pure Java" project build system
alongside of the existing Maven build.

I unfortunately had to use 22 genrules() to provide a number of hacks for
features missing from Buck. The worst hack of all was committing
local.properties to work around the Android SDK. :-)


Reply to this email directly or view it on GitHubhttps://github.com/facebook/buck/issues/7#issuecomment-17292098
.

Contributor

bolinfest commented May 1, 2013

I have a fix for this internally, but I'm waiting for a code review :(

On Wed, May 1, 2013 at 10:02 AM, Shawn O. Pearce
notifications@github.comwrote:

If you are interested in looking at a real world pure Java project's usage
of Buck, see
https://gerrit.googlesource.com/gerrit/+/57a4d597cd1111ebabf9bbf495ecd45324e7acddas it contains a complete, non-trivial "pure Java" project build system
alongside of the existing Maven build.

I unfortunately had to use 22 genrules() to provide a number of hacks for
features missing from Buck. The worst hack of all was committing
local.properties to work around the Android SDK. :-)


Reply to this email directly or view it on GitHubhttps://github.com/facebook/buck/issues/7#issuecomment-17292098
.

@bolinfest

This comment has been minimized.

Show comment
Hide comment
@bolinfest

bolinfest May 2, 2013

Contributor

Fixed:
ef014b3

Contributor

bolinfest commented May 2, 2013

Fixed:
ef014b3

@bolinfest bolinfest closed this May 2, 2013

runningcode added a commit to runningcode/buck that referenced this issue May 24, 2017

Merge pull request #7 in ANDROID/buck from no/merge-upstream to master
* commit '5860f1ccb114d2a1786748603a444996debd09f6': (680 commits)
  Fix crash building Android rules
  Ignore classes within anonymous or local classes
  Fix annotations on inner class constructor params
  Enable `abi_verification_mode=fail`
  Fix stubs for deeply-nested static inner classes
  Fix references to deeply-nested enums
  Close cache at the end of cache command
  Add ndk.extra_ldflags
  Refactor creation of NDK ldflags
  Handle race conditions in Buck project constructor.
  ClassLoaderBootstrapper: Create ClassLoader earlier
  Stop logging "No Android platform target specified" to console
  JarBuilder: Eliminate checkNotNull
  Add more info for cannot delete directory failures
  AndroidLibraryDescription: Move ABI rule construction into the builder
  AndroidLibraryDescription: Move graph enhancement into the builder
  AndroidLibraryDescription: Push provided_deps_query into the builder
  DefaultJavaLibraryBuilder: Factor out getJavac
  DefaultJavaLibraryBuilder: Make initial BuildRuleParams accessible to subclasses
  Plumb TargetGraph and CellPathResolver into DefaultJavaLibraryBuilder
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment