This repository has been archived by the owner on Nov 10, 2023. It is now read-only.
Windows release on CircleCI #2473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zpao
approved these changes
Jun 5, 2020
Comment on lines
+1207
to
+1208
| name: pip install python-magic-bin | ||
| command: python3 -m pip install python-magic-bin |
There was a problem hiding this comment.
These use python-magic-bin but the other step uses python-magic?
There was a problem hiding this comment.
The name of the module on Linux is python-magic and and on Mac/Windows is python-magic-bin.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows release on CircleCI