Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.9.0 #1430

Closed
frontsideair opened this issue Jan 23, 2017 · 16 comments
Closed

Release 0.9.0 #1430

frontsideair opened this issue Jan 23, 2017 · 16 comments
Milestone

Comments

@frontsideair
Copy link
Contributor

Can we have a release before 0.9.0? #1309 is pretty important to me but I see there are a lot of issues within the 0.9.0 tag. Or can we postpone them after 0.9.0?

@gaearon
Copy link
Contributor

gaearon commented Jan 23, 2017

Yea, the plan is to move the more complex issues until 0.10.
I plan to cut 0.9 some time this or the next week.

@joaosoares
Copy link

Is there an estimate on the release of 0.9.0? My team is using flow extensively and the tests integration would be very helpful for us.

@gaearon
Copy link
Contributor

gaearon commented Feb 7, 2017

We'll delay Flow integration until 0.10 alpha which would be out very soon after 0.9.0.

I'm busy with React right now but I know @Timer offered help cutting 0.9.0. So I'm happy to take him up on that offer :-) There's a few things we need to discuss regarding it, happy to do it here or in a separate issue.

@joaosoares
Copy link

Thank you for the answer!

@frontsideair
Copy link
Contributor Author

You can do this @Timer!

By the way, is there a way to use my fork or a commit of react-scripts I'd like in my project? npm allows using a git repo as a package but in this case, I think it won't work due to the monorepo setup. If there's a way I'm missing, please let me know.

@gaearon
Copy link
Contributor

gaearon commented Feb 8, 2017

create-react-app myapp --scripts-version my-react-scripts

This?

@frontsideair
Copy link
Contributor Author

Like that, but I guess I should either publish my form on npm or provide a .tgz which feels a bit overkill since my patch is already merged.

@gaearon
Copy link
Contributor

gaearon commented Feb 8, 2017

Sorry, I don't have a better solution—we're hitting the limits of what npm can do.

@frontsideair
Copy link
Contributor Author

frontsideair commented Feb 8, 2017

No problem; I guess the main problem is that the npm package and the repo don't mean the same thing. One reason is the monorepo setup; there isn't a one-to-one relationship with the repo and generated npm packages. Another other reason would be prepublish hooks, but as far as I can see react-scripts doesn't use it.

Maybe creating a multi-repo fork would work for me, but I don't see how I could keep it synchronized. I previously suggested having a @next npm tag (or having different release stages) but that'd just make error reporting harder. :/

@Timer
Copy link
Contributor

Timer commented Feb 8, 2017

Let's try to cut it today!

I'll be working on this shortly -- anyone's review would be appreciated:

@Timer
Copy link
Contributor

Timer commented Feb 9, 2017

Hey guys, sorry to disappoint but I don't think it's going to happen today.

Build exit codes and PUBLIC_URL support have some pending changes, and ./ is blocked by PUBLIC_URL.

@gaearon gaearon changed the title Release before 0.9.0 Release 0.9.0 Feb 9, 2017
@Timer
Copy link
Contributor

Timer commented Feb 11, 2017

0.9.0 has been released. Please let me know if you encounter any bugs.

@existentialism
Copy link
Contributor

Nice work @Timer!

@Timer
Copy link
Contributor

Timer commented Feb 11, 2017

Thank you, @existentialism!

@Timer Timer closed this as completed Feb 11, 2017
@Timer Timer added this to the 0.9.0 milestone Feb 11, 2017
@frontsideair
Copy link
Contributor Author

Works like a charm, thanks @Timer!

@Timer
Copy link
Contributor

Timer commented Feb 11, 2017

That's reassuring! Thanks @frontsideair.

@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants