Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to ignore certain errors in crash overlay #2098

Closed
gaearon opened this issue May 8, 2017 · 5 comments
Closed

Add a way to ignore certain errors in crash overlay #2098

gaearon opened this issue May 8, 2017 · 5 comments

Comments

@gaearon
Copy link
Contributor

gaearon commented May 8, 2017

There are cases when it’s impossible to catch an error.
For example:

setTimeout(() => {
  throw new Error('Boom');
});

This may happen inside a third party library that user has no access to. We should have some way to ignore errors by message (at least if localStorage is available for the blacklist).

@gaearon gaearon added this to the 0.10.1 milestone May 8, 2017
@Timer
Copy link
Contributor

Timer commented May 8, 2017

When you say ignore, do you mean a hotkey to "ignore this error in the future"? Or a file/package.json entry to ignore regex matches?

Should we just ignore errors that have no stack traces to our application? I think that makes the most sense -- or at least show them up as if they're a warning (when we make the warning overlay, which is more like a warning toaster).

@gaearon
Copy link
Contributor Author

gaearon commented May 8, 2017

Should we just ignore errors that have no stack traces to our application?

This sounds very reasonable. Can we do this?

@Timer
Copy link
Contributor

Timer commented May 8, 2017

This sounds very reasonable. Can we do this?

I don't see why not. Let me play with it.

@gaearon gaearon modified the milestones: 1.0.1, 1.0.x May 19, 2017
@Timer
Copy link
Contributor

Timer commented Sep 29, 2017

This was added in #2128

@Timer Timer closed this as completed Sep 29, 2017
@ericbiewener
Copy link

Looks like feature described in the OP ("We should have some way to ignore errors by message") didn't get implemented. I'd still like that feature. Should I open a new issue, or could we just reopen this one?

@lock lock bot locked and limited conversation to collaborators Jan 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants