Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Consider using eslint-loader `cache` option #740
@kentcdodds mentioned he’s not using
What kind of perf issues exist with
Does enabling that
I don't use CRA with large codebases yet so I don't have perf issues with eslint-loader.
I assume that ESLint's
@gaearon Unfortunately I can't provide the copy/paste metrics (they were lost in chat long ago, but I can give you near exact info)
As a result, we did the following:
Also, I originally implemented
Knowing what I know now, for speeding up builds it would be:
I hope this helps! We may try this again with
added a commit
Feb 16, 2017
Anybody wants to help me to write the tests and do code review? Currently it doesn't pass any of the tests T_T. I've published a fork here https://www.npmjs.com/package/eslint-loader-fs-cache if anybody wants to play with it and compare with the older implementation.
Can we punt this to 0.10 @gaearon? I don't want to risk additional breakages if we forget an edge case (even though using babel's module is a safe bet, but I don't want to rely on it without support from babel too [as in babel switches to the new module]). We might explore an entire webpack caching plugin in 0.10 which will nullify the need for this anyway.
@Timer shall we turn it on again in master?
I learn so much in these mishaps though. It's both stressful and rewarding working on open source... :)
Also, i'm curious about the whole
Is it dll? Or any other one?