New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Webpack to fix source map issues #1188

Merged
merged 1 commit into from Dec 7, 2016

Conversation

Projects
None yet
1 participant
@gaearon
Member

gaearon commented Dec 7, 2016

Should fix #1186.

The fix works because Webpack dependency bumps webpack-core which bumps source-list-map which includes webpack/source-list-map#2.

That fix was necessary because Babel started adding variable names to source maps in babel/babel#3658 but Webpack didn't add support for this format.

@gaearon gaearon added this to the 0.8.2 milestone Dec 7, 2016

@gaearon gaearon added the tag: bug fix label Dec 7, 2016

@gaearon

This comment has been minimized.

Show comment
Hide comment
@gaearon

gaearon Dec 7, 2016

Member

Before this change. Notice how all line numbers are gray: the lines are disabled and I can't put a breakpoint there:

screen shot 2016-12-07 at 12 50 07

After this change. Notice how all lines where it makes sense to put a breakpoint are now enabled:

screen shot 2016-12-07 at 12 51 16

Member

gaearon commented Dec 7, 2016

Before this change. Notice how all line numbers are gray: the lines are disabled and I can't put a breakpoint there:

screen shot 2016-12-07 at 12 50 07

After this change. Notice how all lines where it makes sense to put a breakpoint are now enabled:

screen shot 2016-12-07 at 12 51 16

@gaearon gaearon merged commit 5f57040 into facebook:master Dec 7, 2016

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@gaearon gaearon deleted the gaearon:sourcemaps branch Dec 7, 2016

mofelee added a commit to xiaohu-developer/create-react-app that referenced this pull request Dec 7, 2016

Merge branch 'master' into sparta-webapp
* master: (30 commits)
  Relax peerDependencies for ESLint preset (#1191)
  Update Webpack to fix source map issues (#1188)
  Update webpack prod config (#1181)
  Chrome 'open tab' reuse an empty tab when possible (#1165)
  Use file-loader for svgs (#1180)
  Fix Babel issues in tests by applying the right transforms (#1179)
  [babel-preset-react-app] Temporary fix missing babel plugins (#1177)
  Add Subresource Integrity support (#1176)
  Remove path module from webpack config on eject. (#1175)
  Don't strip stack traces of evaluated webpack bundles (#1050)
  Add deploy to Firebase CDN on template's README (Closes #374) (#1143)
  Update e2e.sh (#1167)
  Document what npm build does and pushState (#933)
  Fix minor typo/grammar (#1099)
  Add "npm run build silently fails" to Troubleshooting (#1168)
  Add testURL to jest config (#1120)
  Make jsx-no-undef rule an error (#1159)
  Update CHANGELOG.md
  Publish
  Update changelog for 0.8.1
  ...

@gaearon gaearon referenced this pull request Dec 7, 2016

Merged

Add changelog for 0.8.2 #1198

@gaearon

This comment has been minimized.

Show comment
Hide comment
@gaearon
Member

gaearon commented Dec 7, 2016

alexdriaguine added a commit to alexdriaguine/create-react-app that referenced this pull request Jan 23, 2017

randycoulman added a commit to CodingZeal/create-react-app that referenced this pull request May 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment