Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CSS processing the same in dev and prod #13011

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

c-w
Copy link

@c-w c-w commented Feb 11, 2023

This pull request is a revival of #8148 given that react-scripts is now on webpack 5 and MiniCssExtractPlugin now supports hot reloading.

With this pull request, we can make CSS processing the same between dev and prod builds which helps in avoiding hard to debug issues where some CSS works fine locally but doesn't work when deployed due to ordering conflicts or similar. It's a problem I ran into recently and currently have to work-around by manually patching react-scripts in postinstall.

Tagging @andriijas @elektronik2k5 @vatz88 who participated in the original pull request.

Co-authored-by: Vatsal Joshi <vatz88@gmail.com>
@facebook-github-bot
Copy link

Hi @c-w!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants