Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
add project name validation #1662
Could be a potential fix for #1649
The main idea is to validate the project name to meet the npm specification. If the validation fails detailed error information is provided to resolve the issue.
Hm, looks like I misjudged the problem when I first woke up (I really need to not look at my laptop until 2 hours after I wake up).
Would you please apply this diff to e2e-simple.sh and push it?
diff --git a/tasks/e2e-simple.sh b/tasks/e2e-simple.sh index 7782fe8..855172c 100755 --- a/tasks/e2e-simple.sh +++ b/tasks/e2e-simple.sh @@ -71,6 +71,11 @@ grep -v "lerna bootstrap" package.json > temp && mv temp package.json npm install mv package.json.bak package.json +# We need to install create-react-app deps to test it +cd "$root_path"/packages/create-react-app +npm install +cd "$root_path" + # If the node version is < 4, the script should just give an error. if [[ `node --version | sed -e 's/^v//' -e 's/\..*//g'` -lt 4 ]] then
It seems you cherry-picked for 8ba11dd.
edit: you did a merge commit, that's fine too