New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added details how to use setupTests.js after eject #2027

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@jiv-e

jiv-e commented Apr 24, 2017

As discussed in #2007, documentation could include information how ejecting affects on otherwise automatic features. This allows to utilize the documentation better after ejecting.

This pull request is sketchy because I don't know how ejecting affects other features than src/setupTests.js. It would be great if you could provide more details.

@anilreddykatta ^

@facebook-github-bot

This comment has been minimized.

Show comment
Hide comment
@facebook-github-bot

facebook-github-bot Apr 24, 2017

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

facebook-github-bot commented Apr 24, 2017

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

@facebook-github-bot

This comment has been minimized.

Show comment
Hide comment
@facebook-github-bot

facebook-github-bot Apr 24, 2017

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

facebook-github-bot commented Apr 24, 2017

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@Timer Timer added this to the 0.9.6 milestone Apr 25, 2017

@Timer Timer modified the milestones: 0.9.6, 1.0.1 May 17, 2017

@gaearon gaearon modified the milestones: 1.0.1, 1.0.x May 19, 2017

@@ -176,6 +176,11 @@ If you aren’t satisfied with the build tool and configuration choices, you can
Instead, it will copy all the configuration files and the transitive dependencies (Webpack, Babel, ESLint, etc) right into your project so you have full control over them. All of the commands except `eject` will still work, but they will point to the copied scripts so you can tweak them. At this point you’re on your own.
Ejecting removes some automatic functionality like:

This comment has been minimized.

@gaearon

gaearon Jun 27, 2017

Member

I'm not very happy with this wording. Let's just mention this next to particular features. The way you did it below is fine.

@gaearon

gaearon Jun 27, 2017

Member

I'm not very happy with this wording. Let's just mention this next to particular features. The way you did it below is fine.

This comment has been minimized.

@jiv-e

jiv-e Jun 27, 2017

Yes, this was a sketch and wording could be improved. I was just thinking it would be beneficial to list the known changes in functionality in one place. It would make it easier to understand the effects of ejecting.

@jiv-e

jiv-e Jun 27, 2017

Yes, this was a sketch and wording could be improved. I was just thinking it would be beneficial to list the known changes in functionality in one place. It would make it easier to understand the effects of ejecting.

jiv_e
Fixed note rendering
Also added link to ejecting.
@Timer

This comment has been minimized.

Show comment
Hide comment
@Timer

Timer Jan 9, 2018

Collaborator

Documented via 1c8a7f3. Thanks for this!

Collaborator

Timer commented Jan 9, 2018

Documented via 1c8a7f3. Thanks for this!

@Timer Timer closed this Jan 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment