Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs with WebSocket proxy information #2305

Merged
merged 2 commits into from Jun 27, 2017

Conversation

Projects
None yet
4 participants
@jamesblight
Copy link
Contributor

commented May 21, 2017

Provides some information on setting up a WebSocket Proxy to avoid confusion. #2260

@YUzhva

This comment has been minimized.

Copy link

commented May 21, 2017

I added small note to your fork: https://github.com/jamesblight/create-react-app/pulls

🍺 Thanks for PR 🍺

@gaearon gaearon added this to the 1.0.8 milestone Jun 27, 2017

@gaearon gaearon merged commit 0ed6c8d into facebook:master Jun 27, 2017

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@gaearon

This comment has been minimized.

Copy link
Member

commented Jun 27, 2017

Thanks for this!

kellyrmilligan added a commit to kellyrmilligan/create-react-app that referenced this pull request Jun 28, 2017

Merge branch 'master' into serve-app-under
* master: (59 commits)
  Better React Native Web support (facebook#2511)
  Bump dependencies (facebook#2658)
  Minor code style edits to user guide (facebook#2660)
  Don't ask to install webpack for using Styleguidist (facebook#2656)
  Put react-scripts in dependencies, not devDependencies (facebook#2657)
  Razzle added to the alternatives (facebook#2517)
  Warn about large bundle sizes (facebook#2648)
  Add instructions to use source-map-explorer (facebook#1641)
  Ignore "Skipping static resource" message from SW precache (facebook#2645)
  Add React Styleguidist (facebook#2044)
  Update ISSUE_TEMPLATE.md (facebook#2643)
  Add Brackets to launchEditor.js (facebook#2637)
  Updated README (facebook#1931)
  Less passive-aggressive issue template
  Added instruction on how to install Prettier (facebook#2006)
  Fix CLI grammar (facebook#1945)
  Update README.md (facebook#1813)
  Add more info about OOM build failiure [docs] (facebook#2060)
  Update docs with WebSocket proxy information (facebook#2305)
  Add yarn example under "Installing a Dependency" (facebook#2362)
  ...

@gaearon gaearon referenced this pull request Jun 28, 2017

Merged

Changelog for 1.0.8 #2664

romaindso added a commit to romaindso/create-react-app that referenced this pull request Jul 10, 2017

Update docs with WebSocket proxy information (facebook#2305)
* Update docs with WebSocket proxy information

* Tweak wording

wmonk referenced this pull request in wmonk/create-react-app-typescript Aug 7, 2017

Update docs with WebSocket proxy information (#2305)
* Update docs with WebSocket proxy information

* Tweak wording

morgs32 added a commit to BrickworkSoftware/create-react-app that referenced this pull request Sep 1, 2017

Update docs with WebSocket proxy information (facebook#2305)
* Update docs with WebSocket proxy information

* Tweak wording

@lock lock bot locked and limited conversation to collaborators Jan 21, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.