Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yarn example under "Installing a Dependency" #2362

Merged
merged 1 commit into from Jun 27, 2017

Conversation

Projects
None yet
3 participants
@BrianDGLS
Copy link
Contributor

commented May 25, 2017

Due to many of the other examples in the README showing both npm and yarn commands.
I have added an example of how to install a dependency using yarn.

Add yarn example under "Installing a Dependency"
Due to many of the other examples in the README showing both `npm` and `yarn` commands.
I have added an example of how to install a dependency using `yarn`.
@facebook-github-bot

This comment has been minimized.

Copy link

commented May 25, 2017

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

@facebook-github-bot

This comment has been minimized.

Copy link

commented May 25, 2017

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@gaearon gaearon added this to the 1.0.8 milestone Jun 27, 2017

@gaearon gaearon merged commit 77993e7 into facebook:master Jun 27, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@gaearon

This comment has been minimized.

Copy link
Member

commented Jun 27, 2017

Looks good, thank you!

kellyrmilligan added a commit to kellyrmilligan/create-react-app that referenced this pull request Jun 28, 2017

Merge branch 'master' into serve-app-under
* master: (59 commits)
  Better React Native Web support (facebook#2511)
  Bump dependencies (facebook#2658)
  Minor code style edits to user guide (facebook#2660)
  Don't ask to install webpack for using Styleguidist (facebook#2656)
  Put react-scripts in dependencies, not devDependencies (facebook#2657)
  Razzle added to the alternatives (facebook#2517)
  Warn about large bundle sizes (facebook#2648)
  Add instructions to use source-map-explorer (facebook#1641)
  Ignore "Skipping static resource" message from SW precache (facebook#2645)
  Add React Styleguidist (facebook#2044)
  Update ISSUE_TEMPLATE.md (facebook#2643)
  Add Brackets to launchEditor.js (facebook#2637)
  Updated README (facebook#1931)
  Less passive-aggressive issue template
  Added instruction on how to install Prettier (facebook#2006)
  Fix CLI grammar (facebook#1945)
  Update README.md (facebook#1813)
  Add more info about OOM build failiure [docs] (facebook#2060)
  Update docs with WebSocket proxy information (facebook#2305)
  Add yarn example under "Installing a Dependency" (facebook#2362)
  ...

@gaearon gaearon referenced this pull request Jun 28, 2017

Merged

Changelog for 1.0.8 #2664

romaindso added a commit to romaindso/create-react-app that referenced this pull request Jul 10, 2017

Add yarn example under "Installing a Dependency" (facebook#2362)
Due to many of the other examples in the README showing both `npm` and `yarn` commands.
I have added an example of how to install a dependency using `yarn`.

wmonk referenced this pull request in wmonk/create-react-app-typescript Aug 7, 2017

Add yarn example under "Installing a Dependency" (#2362)
Due to many of the other examples in the README showing both `npm` and `yarn` commands.
I have added an example of how to install a dependency using `yarn`.

morgs32 added a commit to BrickworkSoftware/create-react-app that referenced this pull request Sep 1, 2017

Add yarn example under "Installing a Dependency" (facebook#2362)
Due to many of the other examples in the README showing both `npm` and `yarn` commands.
I have added an example of how to install a dependency using `yarn`.

@lock lock bot locked and limited conversation to collaborators Jan 21, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.