Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong path expansion in end-to-end test #2388

Merged
merged 2 commits into from May 27, 2017

Conversation

Projects
None yet
2 participants
@gaearon
Copy link
Member

commented May 27, 2017

I don't know if it'll help (probably not).
Trying to figure out why AppVeyor turns

npm test -- --no-cache --testPathPattern=/src/

into

node scripts/test.js --env=jsdom "--no-cache" "--testPathPattern=C:/Program Files/Git/src/"

even though the script itself has quotes around testPathPattern.

@gaearon gaearon changed the title Don't expand globs in end-to-end script Fix wrong path expansion in end-to-end test May 27, 2017

@gaearon

This comment has been minimized.

Copy link
Member Author

commented May 27, 2017

I think this worked (despite weird segfault).

@gaearon gaearon merged commit 2aafaad into master May 27, 2017

2 of 4 checks passed

continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@gaearon gaearon added this to the 1.0.8 milestone May 27, 2017

gaearon added a commit that referenced this pull request May 27, 2017

gaearon added a commit that referenced this pull request May 27, 2017

Revert "Catch "No tests found" during CI" (#2390)
* Revert "Fix wrong path expansion in end-to-end test (#2388)"

This reverts commit 2aafaad.

* Revert "Suggest just "yarn build" (#2385)"

This reverts commit 70bf125.

* Revert "Catch "No tests found" during CI (#2387)"

This reverts commit 5317b3f.

zangrafx added a commit to zangrafx/create-react-app that referenced this pull request May 31, 2017

Merge branch 'master' into zangrafx
* master:
  Add WebStorm >2017 launchEditor Support (facebook#2414)
  docs: update `jest-enzyme` section (facebook#2392)
  Fix detection of parent directory in ModuleScopePlugin (facebook#2405)
  Added cache clear to e2e scripts (facebook#2400)
  Fix kill command in e2e-kitchensink.sh cleanup (facebook#2397)
  Revert "Catch "No tests found" during CI" (facebook#2390)
  Fix wrong path expansion in end-to-end test (facebook#2388)
  Suggest just "yarn build" (facebook#2385)
  Catch "No tests found" during CI (facebook#2387)
  Publish
  Add changelog for 1.0.7 (facebook#2384)
  Update webpack to 2.6.1 (facebook#2383)
  Consistently set environment variables (facebook#2382)
  Disable comparisons feature in uglify compression in production (facebook#2379)
  Removed the overriding of reduce_vars to false since webpack v2.6.0 included the fixed for Uglify bug (facebook#2351)

kellyrmilligan added a commit to kellyrmilligan/create-react-app that referenced this pull request May 31, 2017

Merge branch 'master' into serve-app-under
* master:
  Fix docs typo (facebook#2420)
  Add WebStorm >2017 launchEditor Support (facebook#2414)
  docs: update `jest-enzyme` section (facebook#2392)
  Fix detection of parent directory in ModuleScopePlugin (facebook#2405)
  Added cache clear to e2e scripts (facebook#2400)
  Fix kill command in e2e-kitchensink.sh cleanup (facebook#2397)
  Revert "Catch "No tests found" during CI" (facebook#2390)
  Fix wrong path expansion in end-to-end test (facebook#2388)
  Suggest just "yarn build" (facebook#2385)
  Catch "No tests found" during CI (facebook#2387)
  Publish
  Add changelog for 1.0.7 (facebook#2384)
  Update webpack to 2.6.1 (facebook#2383)
  Consistently set environment variables (facebook#2382)
  Disable comparisons feature in uglify compression in production (facebook#2379)
  Removed the overriding of reduce_vars to false since webpack v2.6.0 included the fixed for Uglify bug (facebook#2351)
  Update README.md for `now` deployments (facebook#2372)
  Print file sizes with correct build folder path. (facebook#2361)
  Fix broken links (facebook#2350)
  Update webpack to v2.6.0 in react-scripts (facebook#2349)

@gaearon gaearon referenced this pull request Jun 28, 2017

Merged

Changelog for 1.0.8 #2664

christensena added a commit to christensena/create-react-app that referenced this pull request Jul 8, 2017

Fix wrong path expansion in end-to-end test (facebook#2388)
* Update e2e-kitchensink.sh

* Try again (differently)

christensena added a commit to christensena/create-react-app that referenced this pull request Jul 8, 2017

Revert "Catch "No tests found" during CI" (facebook#2390)
* Revert "Fix wrong path expansion in end-to-end test (facebook#2388)"

This reverts commit 2aafaad.

* Revert "Suggest just "yarn build" (facebook#2385)"

This reverts commit 70bf125.

* Revert "Catch "No tests found" during CI (facebook#2387)"

This reverts commit 5317b3f.

romaindso added a commit to romaindso/create-react-app that referenced this pull request Jul 10, 2017

Fix wrong path expansion in end-to-end test (facebook#2388)
* Update e2e-kitchensink.sh

* Try again (differently)

romaindso added a commit to romaindso/create-react-app that referenced this pull request Jul 10, 2017

Revert "Catch "No tests found" during CI" (facebook#2390)
* Revert "Fix wrong path expansion in end-to-end test (facebook#2388)"

This reverts commit 2aafaad.

* Revert "Suggest just "yarn build" (facebook#2385)"

This reverts commit 70bf125.

* Revert "Catch "No tests found" during CI (facebook#2387)"

This reverts commit 5317b3f.

wmonk referenced this pull request in wmonk/create-react-app-typescript Aug 7, 2017

Fix wrong path expansion in end-to-end test (#2388)
* Update e2e-kitchensink.sh

* Try again (differently)

wmonk referenced this pull request in wmonk/create-react-app-typescript Aug 7, 2017

Revert "Catch "No tests found" during CI" (#2390)
* Revert "Fix wrong path expansion in end-to-end test (#2388)"

This reverts commit 2aafaad.

* Revert "Suggest just "yarn build" (#2385)"

This reverts commit 70bf125.

* Revert "Catch "No tests found" during CI (#2387)"

This reverts commit 5317b3f.

@Timer Timer deleted the gaearon-patch-10 branch Oct 31, 2017

@lock lock bot locked and limited conversation to collaborators Jan 20, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.