Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Added link to tutorial on code splitting #2427

Merged
merged 2 commits into from Jun 26, 2017

Conversation

Projects
None yet
3 participants
@jayair
Copy link
Contributor

commented May 31, 2017

Link to tutorial on Code Splitting with React Router

Adding link to tutorial on code splitting
Link to tutorial on Code Splitting with React Router
@facebook-github-bot

This comment has been minimized.

Copy link

commented May 31, 2017

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

@facebook-github-bot

This comment has been minimized.

Copy link

commented Jun 3, 2017

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@jayair jayair changed the title Adding link to tutorial on code splitting Docs: Added link to tutorial on code splitting Jun 3, 2017

@gaearon gaearon added this to the 1.0.8 milestone Jun 26, 2017

@gaearon gaearon merged commit 76bd132 into facebook:master Jun 26, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@gaearon

This comment has been minimized.

Copy link
Member

commented Jun 26, 2017

Looks great. Thanks!

@gaearon gaearon referenced this pull request Jun 28, 2017

Merged

Changelog for 1.0.8 #2664

romaindso added a commit to romaindso/create-react-app that referenced this pull request Jul 10, 2017

Docs: Added link to tutorial on code splitting (facebook#2427)
* Adding link to tutorial on code splitting

Link to tutorial on Code Splitting with React Router

* Update README.md

wmonk referenced this pull request in wmonk/create-react-app-typescript Aug 7, 2017

Docs: Added link to tutorial on code splitting (#2427)
* Adding link to tutorial on code splitting

Link to tutorial on Code Splitting with React Router

* Update README.md

morgs32 added a commit to BrickworkSoftware/create-react-app that referenced this pull request Sep 1, 2017

Docs: Added link to tutorial on code splitting (facebook#2427)
* Adding link to tutorial on code splitting

Link to tutorial on Code Splitting with React Router

* Update README.md

@lock lock bot locked and limited conversation to collaborators Jan 21, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.