Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prioritize index.css over the implicit App.css #2470

Merged
merged 1 commit into from Jun 5, 2017

Conversation

Projects
None yet
4 participants
@bananatranada
Copy link

commented Jun 4, 2017

Hi. I'm under the assumption that index.css is used for global styles not associated with any component. This is where I import 3rd party css libraries as well. However, I noticed that it would override the styles in App.css.

@facebook-github-bot

This comment has been minimized.

Copy link

commented Jun 4, 2017

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

@facebook-github-bot

This comment has been minimized.

Copy link

commented Jun 4, 2017

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@gaearon gaearon added the tag: bug fix label Jun 5, 2017

@gaearon gaearon added this to the 1.0.8 milestone Jun 5, 2017

@gaearon

This comment has been minimized.

Copy link
Member

commented Jun 5, 2017

That’s a good catch.

@gaearon gaearon merged commit b264b8d into facebook:master Jun 5, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

paweljedrzejczyk added a commit to paweljedrzejczyk/create-react-app that referenced this pull request Jun 12, 2017

Update from upstream repo facebookincubator/create-react-app (#1)
* Update Travis CI Node versions in User Guide (facebook#2454)

Removed Node v4 (CRA only supports Node >= 6)

* re-add storybook && update the documentation and links (facebook#2331)

* re-add storybook && update the documentation and links

* Change to new documentation domain

* Prioritize index.css over the implicit App.css (facebook#2470)

* Added NamedModulesPlugin in webpack.config.dev.js (facebook#2458)

* Added NamedModulesPlugin in webpack.config.dev.js

* Update webpack.config.dev.js

* Unscope detect-port (facebook#2483)

Resolves facebook#2481

* Update webpack links to point to webpack 2 (facebook#2492)

* Update README.md to make links to webpack point to webpack.js.org instead
  insteade of webpack 1 webpack.githup.io

* chore(templates): Move GitHub templates to hidden .github folder (facebook#2489)

* Fix minor docs typo (facebook#2500)

* Fix link to Storybook docs (facebook#2521)

* Simplify flow init docs (facebook#2522)

- Call `npm run flow --init` won't create a .flowconfig file, it should be `npm run flow init`

@gaearon gaearon referenced this pull request Jun 28, 2017

Merged

Changelog for 1.0.8 #2664

@gaearon

This comment has been minimized.

Copy link
Member

commented Jun 28, 2017

Fixed in latest version. Please verify.
https://github.com/facebookincubator/create-react-app/releases/tag/v1.0.8

romaindso added a commit to romaindso/create-react-app that referenced this pull request Jul 10, 2017

wmonk referenced this pull request in wmonk/create-react-app-typescript Aug 7, 2017

@lock lock bot locked and limited conversation to collaborators Jan 21, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.