Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PhpStorm in launchEditor #2622

Merged
merged 1 commit into from Jun 26, 2017

Conversation

Projects
None yet
3 participants
@miraage
Copy link
Contributor

miraage commented Jun 26, 2017

https://www.jetbrains.com/help/webstorm/opening-files-from-command-line.html
https://www.jetbrains.com/help/phpstorm/opening-files-from-command-line.html

Both editors have the same signature <editor> <projectPath> --line <number> <filePath> to open file from the command line.
It seems to work even if <projectPath> is omitted (commit 02f88ba).

Tested on Win10+PhpStorm2016 and macOS 10.12+PhpStorm2017.

Support PhpStorm in launchEditor
https://www.jetbrains.com/help/webstorm/opening-files-from-command-line.html
https://www.jetbrains.com/help/phpstorm/opening-files-from-command-line.html

Both editors have the same signature `<editor> <projectPath> --line <number> <filePath>` to open file from the command line.
It seems to work even if `<projectPath>` is omitted (commit 02f88ba).

Tested on `Win10`+`PhpStorm2016` and `macOS 10.12`+`PhpStorm2017`.

@gaearon gaearon added this to the 1.0.8 milestone Jun 26, 2017

@gaearon gaearon merged commit 58ef08f into facebook:master Jun 26, 2017

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@gaearon

This comment has been minimized.

Copy link
Member

gaearon commented Jun 26, 2017

This looks great. Thanks!

@miraage miraage deleted the miraage:patch-1 branch Jun 26, 2017

@gaearon gaearon referenced this pull request Jun 28, 2017

Merged

Changelog for 1.0.8 #2664

@gaearon

This comment has been minimized.

Copy link
Member

gaearon commented Jun 28, 2017

romaindso added a commit to romaindso/create-react-app that referenced this pull request Jul 10, 2017

Support PhpStorm in launchEditor (facebook#2622)
https://www.jetbrains.com/help/webstorm/opening-files-from-command-line.html
https://www.jetbrains.com/help/phpstorm/opening-files-from-command-line.html

Both editors have the same signature `<editor> <projectPath> --line <number> <filePath>` to open file from the command line.
It seems to work even if `<projectPath>` is omitted (commit 02f88ba).

Tested on `Win10`+`PhpStorm2016` and `macOS 10.12`+`PhpStorm2017`.

wmonk referenced this pull request in wmonk/create-react-app-typescript Aug 7, 2017

Support PhpStorm in launchEditor (#2622)
https://www.jetbrains.com/help/webstorm/opening-files-from-command-line.html
https://www.jetbrains.com/help/phpstorm/opening-files-from-command-line.html

Both editors have the same signature `<editor> <projectPath> --line <number> <filePath>` to open file from the command line.
It seems to work even if `<projectPath>` is omitted (commit 02f88ba).

Tested on `Win10`+`PhpStorm2016` and `macOS 10.12`+`PhpStorm2017`.

morgs32 added a commit to BrickworkSoftware/create-react-app that referenced this pull request Sep 1, 2017

Support PhpStorm in launchEditor (facebook#2622)
https://www.jetbrains.com/help/webstorm/opening-files-from-command-line.html
https://www.jetbrains.com/help/phpstorm/opening-files-from-command-line.html

Both editors have the same signature `<editor> <projectPath> --line <number> <filePath>` to open file from the command line.
It seems to work even if `<projectPath>` is omitted (commit 02f88ba).

Tested on `Win10`+`PhpStorm2016` and `macOS 10.12`+`PhpStorm2017`.

@lock lock bot locked and limited conversation to collaborators Jan 21, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.