Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Node 8 on Travis #2659

Merged
merged 11 commits into from Jun 28, 2017

Conversation

Projects
None yet
3 participants
@gaearon
Copy link
Member

commented Jun 28, 2017

We still test Node 7 on AppVeyor

Test Node 8 on Travis
We still test Node 7 on AppVeyor

gaearon added some commits Jun 28, 2017

@gaearon

This comment has been minimized.

Copy link
Member Author

commented Jun 28, 2017

Um, this doesn't look amazing 😞

> fsevents@1.1.2 install /tmp/tmp.nEJmaLIQL1/test-app/node_modules/fsevents
> node install
npm ERR! Cannot read property 'type' of undefined

@gaearon gaearon referenced this pull request Jun 28, 2017

Merged

Upgrade fsevents to 1.1.2 #2550

gaearon added some commits Jun 28, 2017

@gaearon

This comment has been minimized.

Copy link
Member Author

commented Jun 28, 2017

Seems like this error is npm@5.0.3 bug npm/npm#16812.
Trying to force 5.0.4+ with my non-existent bash skills.

@gaearon

This comment has been minimized.

Copy link
Member Author

commented Jun 28, 2017

Heh. Seems like no chance to run with npm@5:

> @ build C:\projects\create-react-app-a3khu
> node packages/react-scripts/scripts/build.js
module.js:472
    throw err;
    ^
Error: Cannot find module 'html-webpack-plugin'
    at Function.Module._resolveFilename (module.js:470:15)
    at Function.Module._load (module.js:418:25)
    at Module.require (module.js:498:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (C:\projects\create-react-app-a3khu\packages\react-scripts\config\webpack.config.prod.js:16:27)
    at Module._compile (module.js:571:32)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:488:32)
    at tryModuleLoad (module.js:447:12)
    at Function.Module._load (module.js:439:3)
npm ERR! Windows_NT 10.0.14393

I'll try to pin it at 4.x so that we can at least test Node 8 alone.

gaearon added some commits Jun 28, 2017

@gaearon gaearon added this to the 1.0.9 milestone Jun 28, 2017

@gaearon gaearon merged commit 657b3fd into master Jun 28, 2017

3 of 4 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@Timer Timer deleted the gaearon-patch-17 branch Jun 29, 2017

@Timer

This comment has been minimized.

Copy link
Collaborator

commented Jun 29, 2017

Was there a specific reason we don't test Node 8 on AppVeyor?

@gaearon

This comment has been minimized.

Copy link
Member Author

commented Jun 29, 2017

I don't want to make CI time slower. So I'd rather test two versions here and two versions there. This doesn't catch everything but that's the tradeoff.

zangrafx added a commit to absolvent/create-react-app that referenced this pull request Jun 29, 2017

Merge remote-tracking branch 'upstream/master'
* upstream/master: (55 commits)
  Fix minor typo (facebook#2679)
  Bootstrap with Yarn when available (facebook#2673)
  Add more info about apache client side routing (facebook#2666)
  Test Node 8 on Travis (facebook#2659)
  Add json and css to lint-staged in template README (facebook#2671)
  Add a note about fixed vulnerability in 1.0.8
  Publish
  Changelog for 1.0.8 (facebook#2664)
  Reformat source code with Prettier 1.5.2
  Update Prettier to v1 (facebook#2465)
  Update ISSUE_TEMPLATE.md
  Local testing docker links (facebook#2662)
  Better React Native Web support (facebook#2511)
  Bump dependencies (facebook#2658)
  Minor code style edits to user guide (facebook#2660)
  Don't ask to install webpack for using Styleguidist (facebook#2656)
  Put react-scripts in dependencies, not devDependencies (facebook#2657)
  Razzle added to the alternatives (facebook#2517)
  Warn about large bundle sizes (facebook#2648)
  Add instructions to use source-map-explorer (facebook#1641)
  ...

# Conflicts:
#	packages/react-dev-utils/package.json
#	packages/react-scripts/config/webpack.config.dev.js
#	packages/react-scripts/config/webpack.config.prod.js
#	packages/react-scripts/package.json

@gaearon gaearon referenced this pull request Jun 29, 2017

Merged

Changelog for 1.0.9 #2682

romaindso added a commit to romaindso/create-react-app that referenced this pull request Jul 10, 2017

Test Node 8 on Travis (facebook#2659)
* Test Node 8 on Travis

We still test Node 7 on AppVeyor

* Update e2e-installs.sh

* Update e2e-kitchensink.sh

* Update e2e-simple.sh

* Update e2e-installs.sh

* Update e2e-kitchensink.sh

* Update e2e-installs.sh

* Update e2e-simple.sh

* Update e2e-simple.sh

* Update e2e-kitchensink.sh

* Update e2e-installs.sh

wmonk referenced this pull request in wmonk/create-react-app-typescript Aug 7, 2017

Test Node 8 on Travis (#2659)
* Test Node 8 on Travis

We still test Node 7 on AppVeyor

* Update e2e-installs.sh

* Update e2e-kitchensink.sh

* Update e2e-simple.sh

* Update e2e-installs.sh

* Update e2e-kitchensink.sh

* Update e2e-installs.sh

* Update e2e-simple.sh

* Update e2e-simple.sh

* Update e2e-kitchensink.sh

* Update e2e-installs.sh

morgs32 added a commit to BrickworkSoftware/create-react-app that referenced this pull request Sep 1, 2017

Test Node 8 on Travis (facebook#2659)
* Test Node 8 on Travis

We still test Node 7 on AppVeyor

* Update e2e-installs.sh

* Update e2e-kitchensink.sh

* Update e2e-simple.sh

* Update e2e-installs.sh

* Update e2e-kitchensink.sh

* Update e2e-installs.sh

* Update e2e-simple.sh

* Update e2e-simple.sh

* Update e2e-kitchensink.sh

* Update e2e-installs.sh

@lock lock bot locked and limited conversation to collaborators Jan 21, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.