Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Local testing docker links #2662

Merged
merged 2 commits into from Jun 28, 2017
Merged

Local testing docker links #2662

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db84d25
Fix a command style in docs
EnoahNetzach Jun 28, 2017
9147cd6
Add a link to docker's docs
EnoahNetzach Jun 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Expand Up @@ -92,7 +92,7 @@ and then run `npm start` or `npm run build`.

## Contributing to E2E (end to end) tests

**TL;DR** use the command yarn e2e:docker to run unit and e2e tests.
**TL;DR** use the command `yarn e2e:docker` to run unit and e2e tests.

More detailed information are in the dedicated [README](/packages/react-scripts/fixtures/kitchensink/README.md).

Expand Down
2 changes: 2 additions & 0 deletions packages/react-scripts/fixtures/kitchensink/README.md
View file
Open in desktop
Expand Up @@ -10,6 +10,8 @@ In order to run them locally, without having to manually install and configure e
This is a simple script that runs a **Docker** container, where the node version, git branch to clone, test suite, and whether to run it with `yarn` or `npm` can be chosen.
Simply run `yarn e2e:docker -- --help` to get additional info.

If you need guidance installing **Docker**, you should follow their [official docs](https://docs.docker.com/engine/installation/).

## Writing tests

Each time a new feature is added, it is advised to add at least one test covering it.
Expand Down