Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't prompt to install serve if already installed #2761

Merged
merged 3 commits into from Jul 10, 2017

Conversation

Projects
None yet
5 participants
@OwenFlood
Copy link
Contributor

commented Jul 10, 2017

This PR (#2750) removes the line prompting to install serve if the user already has it installed globally. Tested on Mac OS with and without serve installed.

@facebook-github-bot

This comment has been minimized.

Copy link

commented Jul 10, 2017

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot

This comment has been minimized.

Copy link

commented Jul 10, 2017

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@gaearon gaearon added this to the 1.0.11 milestone Jul 10, 2017

@gaearon

This comment has been minimized.

Copy link
Member

commented Jul 10, 2017

Looks fine to me! Let's wait for CI to pass.
Thank you!

@gaearon gaearon merged commit 3690495 into facebook:master Jul 10, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@gurbraj

This comment has been minimized.

Copy link

commented Jul 11, 2017

Wow, sick PR Owen.

Would push the 'owen-dank1' button if I could.

@Timer

This comment has been minimized.

Copy link
Collaborator

commented Aug 9, 2017

Hi there! This change is out in react-scripts@1.0.11; please give it a go! Thanks.

JohnNilsson referenced this pull request in JohnNilsson/create-react-app-typescript Aug 9, 2017

Don't prompt to install serve if already installed (#2761)
* dont prompt if serve is already installed

* change name for readability

* Pin the version

morgs32 added a commit to BrickworkSoftware/create-react-app that referenced this pull request Sep 1, 2017

Don't prompt to install serve if already installed (facebook#2761)
* dont prompt if serve is already installed

* change name for readability

* Pin the version

JohnNilsson referenced this pull request in JohnNilsson/create-react-app-typescript Sep 9, 2017

Don't prompt to install serve if already installed (#2761)
* dont prompt if serve is already installed

* change name for readability

* Pin the version

kasperpeulen added a commit to kasperpeulen/create-react-app that referenced this pull request Sep 24, 2017

Don't prompt to install serve if already installed (facebook#2761)
* dont prompt if serve is already installed

* change name for readability

* Pin the version

swengorschewski referenced this pull request in swengorschewski/cra-typescript-electron Oct 16, 2017

Don't prompt to install serve if already installed (#2761)
* dont prompt if serve is already installed

* change name for readability

* Pin the version

@lock lock bot locked and limited conversation to collaborators Jan 21, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.