Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use of scoped packages with a pinned version #2853

Merged
merged 1 commit into from Aug 2, 2017

Conversation

Projects
None yet
3 participants
@wileybenet
Copy link
Contributor

commented Jul 25, 2017

When specifying a --scripts-version, the first @ in a scoped package prevents the packageName from being trimmed of its version tag, if it has one. Hence, an uncaught error is thrown when the full, pinned package name is used in the path to read package.json:

screen shot 2017-07-25 at 3 38 14 pm

I added the .match() to yield a truthy value if the installPackage contains an @ symbol at char 0 and at char 1+. To test that this works, run create-react-app --scripts-version=@organization/my-react-scripts@0.0.1 and see that create-react-app completed successfully and that the correct package version was installed:

screen shot 2017-07-25 at 3 44 29 pm

@facebook-github-bot

This comment has been minimized.

Copy link

commented Jul 25, 2017

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@wileybenet wileybenet closed this Jul 25, 2017

@wileybenet wileybenet reopened this Jul 25, 2017

@facebook-github-bot

This comment has been minimized.

Copy link

commented Jul 25, 2017

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@Timer

This comment has been minimized.

Copy link
Collaborator

commented Aug 2, 2017

Nice catch, thanks!

@Timer Timer merged commit ea9427b into facebook:master Aug 2, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Timer

This comment has been minimized.

Copy link
Collaborator

commented Aug 9, 2017

Hi there! This change is out in react-scripts@1.0.11; please give it a go! Thanks.

JohnNilsson referenced this pull request in JohnNilsson/create-react-app-typescript Aug 9, 2017

zangrafx added a commit to absolvent/create-react-app that referenced this pull request Aug 13, 2017

Merge commit 'bfaee410c502a95076a6bd89721c76ca08e15f7b'
* commit 'bfaee410c502a95076a6bd89721c76ca08e15f7b': (39 commits)
  Publish
  Prepare for 1.0.11 release (facebook#2924)
  Update dev deps (facebook#2923)
  Update README.md
  Use env variable to disable source maps (facebook#2818)
  Make formatWebpackMessages return all messages (facebook#2834)
  Adjust the `checkIfOnline` check if in a corporate proxy environment (facebook#2884)
  Fix the order of arguments in spawned child proc (facebook#2913)
  Feature/webpack 3 4 (facebook#2875)
  Allow importing package.json (facebook#2468)
  Re-enable flowtype warning (facebook#2718)
  Format UglifyJs error (facebook#2650)
  Unstage yarn.lock pre-commit (facebook#2700)
  Update README.md
  Update README.md
  Add Electrode to alternatives (facebook#2728)
  Fix parsing HTML/JSX tags to real elements (facebook#2796)
  Update webpack version note (facebook#2798)
  Use modern syntax feature (facebook#2873)
  Allow use of scoped packages with a pinned version (facebook#2853)
  ...

# Conflicts:
#	packages/react-scripts/config/webpack.config.dev.js
#	packages/react-scripts/config/webpack.config.prod.js
#	packages/react-scripts/package.json

JohnNilsson referenced this pull request in JohnNilsson/create-react-app-typescript Sep 9, 2017

Ayc0 pushed a commit to Ayc0/create-react-app that referenced this pull request Sep 18, 2017

kasperpeulen added a commit to kasperpeulen/create-react-app that referenced this pull request Sep 24, 2017

swengorschewski referenced this pull request in swengorschewski/cra-typescript-electron Oct 16, 2017

jdcrensh added a commit to jdcrensh/create-react-app that referenced this pull request Oct 24, 2017

mrmckeb pushed a commit to mrmckeb/create-react-app that referenced this pull request Nov 6, 2018

@lock lock bot locked and limited conversation to collaborators Jan 21, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.