Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use safer/more aesthetic syntax for setting environment variables on Windows #3533

Merged

Conversation

Projects
None yet
3 participants
@cdanielsen
Copy link
Contributor

cdanielsen commented Nov 30, 2017

(Cleaned up version of #3530)

Documentation update to fix a maddeningly easy oversite for Windows users. The SET command allows for wrapping the variable assignment expression with double quotes. Using this method negates the need to smash two commands together with the && operator as currently documented.

@cdanielsen

This comment has been minimized.

Copy link
Contributor Author

cdanielsen commented Dec 20, 2017

@Timer any thoughts on this?

@Timer

This comment has been minimized.

Copy link
Collaborator

Timer commented Jan 2, 2018

I like this. Thanks!

@Timer Timer added this to the 1.0.18 milestone Jan 2, 2018

@Timer Timer merged commit 76e3165 into facebook:master Jan 2, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@cdanielsen cdanielsen deleted the cdanielsen:improve-documentation-for-windows-users branch Jan 2, 2018

@gaearon gaearon referenced this pull request Jan 15, 2018

Merged

Changelog for 1.1.0 #3795

tabrindle added a commit to tabrindle/create-react-app that referenced this pull request Jan 18, 2018

Pavek pushed a commit to Pavek/create-react-app that referenced this pull request Jul 10, 2018

Use friendlier syntax for setting env var on Windows (facebook#3533)
* use safer/more aesthetic syntax

* fix typo

zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Aug 14, 2018

@lock lock bot locked and limited conversation to collaborators Jan 20, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.