Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates comment to reflect codebase #3576

Merged
merged 1 commit into from Dec 11, 2017

Conversation

Projects
None yet
3 participants
@rahulcs
Copy link
Contributor

rahulcs commented Dec 11, 2017

the code got updated from detect() to choosePort() while the comment did not.

updates comment to reflect codebase
the code got updated from `detect()` to `choosePort` while the comment did not.
@facebook-github-bot

This comment has been minimized.

Copy link

facebook-github-bot commented Dec 11, 2017

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot

This comment has been minimized.

Copy link

facebook-github-bot commented Dec 11, 2017

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@Timer

This comment has been minimized.

Copy link
Collaborator

Timer commented Dec 11, 2017

Thanks!

@Timer Timer added this to the 1.0.17 milestone Dec 11, 2017

@Timer Timer merged commit a1c5b8f into facebook:master Dec 11, 2017

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@rahulcs rahulcs deleted the rahulcs:patch-1 branch Dec 11, 2017

kellyrmilligan added a commit to kellyrmilligan/create-react-app that referenced this pull request Dec 15, 2017

Merge branch 'master' into serve-app-under
* master:
  Updates comment to reflect codebase (facebook#3576)
  Add mjs and jsx filename extensions to file-loader exclude pattern (facebook#3537)

@gaearon gaearon referenced this pull request Jan 15, 2018

Merged

Changelog for 1.1.0 #3795

tabrindle added a commit to tabrindle/create-react-app that referenced this pull request Jan 18, 2018

Updates comment to reflect codebase (facebook#3576)
the code got updated from `detect()` to `choosePort` while the comment did not.

Pavek pushed a commit to Pavek/create-react-app that referenced this pull request Jul 10, 2018

Updates comment to reflect codebase (facebook#3576)
the code got updated from `detect()` to `choosePort` while the comment did not.

zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Aug 14, 2018

Updates comment to reflect codebase (facebook#3576)
the code got updated from `detect()` to `choosePort` while the comment did not.

@lock lock bot locked and limited conversation to collaborators Jan 20, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.