Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update screencast to use npx #3810

Merged
merged 6 commits into from Jan 16, 2018

Conversation

Projects
None yet
4 participants
@marionebl
Copy link
Contributor

marionebl commented Jan 15, 2018

As asked in #3677, this updates the screencast to use npx.

@gaearon

This comment has been minimized.

Copy link
Member

gaearon commented Jan 15, 2018

Can you please remove unrelated edits and change the PR target to be next?

@marionebl marionebl changed the base branch from master to next Jan 16, 2018

@marionebl marionebl force-pushed the marionebl:docs-svg-demo branch 2 times, most recently from 005dfb5 to 0da8db2 Jan 16, 2018

marionebl added some commits Jan 15, 2018

@marionebl marionebl force-pushed the marionebl:docs-svg-demo branch from 0da8db2 to cb20285 Jan 16, 2018

@marionebl

This comment has been minimized.

Copy link
Contributor Author

marionebl commented Jan 16, 2018

Done! Struggled a bit with getting changes from next merged cleanly

@gaearon

This comment has been minimized.

Copy link
Member

gaearon commented Jan 16, 2018

I hate to be nitpicky but any chance you could make it so that we don't see the history of the past npx calls being autocompleted?

marionebl added some commits Jan 16, 2018

Update screencast to version without history
* The previous version was recorded on a fish shell, which has
a history suggestion feature that can not be disabled

* The new version uses zsh as shell to avoid the history
suggestions in the cast

* The new version has been created with scripts that are subject
of a separate PR

@gaearon gaearon added this to the 2.x milestone Jan 16, 2018

@gaearon gaearon merged commit 272edff into facebook:next Jan 16, 2018

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

akstuhl added a commit to akstuhl/create-react-app that referenced this pull request Mar 15, 2018

Update screencast to use npx (facebook#3810)
* Use npx for screencast

* Use updated screencast

* Update screencast to version without history

* The previous version was recorded on a fish shell, which has
a history suggestion feature that can not be disabled

* The new version uses zsh as shell to avoid the history
suggestions in the cast

* The new version has been created with scripts that are subject
of a separate PR

* Use screencast without autosuggestions

@Timer Timer modified the milestones: 2.x, 2.0.0 Oct 1, 2018

@lock lock bot locked and limited conversation to collaborators Jan 19, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.