Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Enable grid prefixing via autoprefixer options object #4756
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.
If you have received this in error or have any questions, please contact us at firstname.lastname@example.org. Thanks!
referenced this pull request
Sep 27, 2018
This option should not be enabled by default. Developer must understand limits before using it.
I suggest to add
I think it's reasonable to leave it on here. In our case, the user doesn't set up autoprefixing themselves. If they were, it makes sense for the option to be off because Autoprefixer is expected to be correct.
However in our case autoprefixing happens "behind the curtains". So you don't expect it to work in 100% of cases because you don't think about it that much in the first place. Therefore, I think it makes sense that we do best effort to support IE here. Worst case — your layout is just as broken as it would be if we left it off. You'd have to test it in IE regardless.
I agree it would be bad for Autoprefixer to make it on by default because it would hurt its brand as a "correct" tool. But in our case I think it's okay because I can't see the harmful scenario it attempts to prevent. We can add it to User Guide in any case.
@Timer it could not automagically apply to any CSS. CSS should be written with limits in mind.
Here is a good guide about the limits:
This is why calling
Also, it is a popular way to exclude
But I agree that we may have cases when we need to run PostCSS and Babel on npm packages. But I do not see a way to resolve it without adding
Yeap. I added the task to our Cult of Martians https://cultofmartians.com/tasks/autoprefixer-grid-comment.html
I think it will be done in next week (maybe two).