New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onOffline/onError callbacks in serviceWorker.js (next) #4816

Closed
wants to merge 1 commit into
base: next
from

Conversation

Projects
None yet
3 participants
@natrim

natrim commented Jul 24, 2018

Hello,

i added onOffline and onError callback to the serviceWorker.js

They are useful ie. to display user message when in offline
and ie. to log the error on serviceWorker register fail.

@facebook-github-bot

This comment has been minimized.

Show comment
Hide comment
@facebook-github-bot

facebook-github-bot Jul 24, 2018

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented Jul 24, 2018

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot

This comment has been minimized.

Show comment
Hide comment
@facebook-github-bot

facebook-github-bot Jul 24, 2018

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

facebook-github-bot commented Jul 24, 2018

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@natrim natrim changed the title from Add onOffline/onError callbacks in serviceWorker (next) to Add onOffline/onError callbacks in serviceWorker.js (next) Aug 5, 2018

@Timer

This comment has been minimized.

Show comment
Hide comment
@Timer

Timer Sep 21, 2018

Collaborator

Hey! Thanks for this but we're currently switching to Workbox and are going to make service workers super configurable, so this change is out of scope for now.

Collaborator

Timer commented Sep 21, 2018

Hey! Thanks for this but we're currently switching to Workbox and are going to make service workers super configurable, so this change is out of scope for now.

@Timer Timer closed this Sep 21, 2018

@natrim

This comment has been minimized.

Show comment
Hide comment
@natrim

natrim Oct 2, 2018

the 2.0 release has still the old serviceWorker.js though? so this PR should still be relevant

natrim commented Oct 2, 2018

the 2.0 release has still the old serviceWorker.js though? so this PR should still be relevant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment