Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a custom URL to be opened #5001

Closed
wants to merge 1 commit into from
Closed

Allow a custom URL to be opened #5001

wants to merge 1 commit into from

Conversation

exalted
Copy link

@exalted exalted commented Sep 12, 2018

Open a specific URL instead of hard-coded / path.

For example, BROWSER_URL='http://localhost:3000/admin' react-scripts start, would open http://localhost:3000/admin in user's default browser, instead of http://localhost:3000/ (that is if custom PROTOCOL, HOST, and PORT are not provided).

This aligns perfectly, in my opinion, with existing behavior of opening with a different browser (i.e. BROWSER='google chrome' react-scripts start).

What do you think?

Open a specific URL instead of hard-coded `/` path.
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@Timer
Copy link
Contributor

Timer commented Sep 21, 2018

Hi! We appreciate this pull request but opted to let users achieve this behavior via a script. You can set BROWSER to script.js and have it run that script for you. You can do anything you want in this script.

@Timer Timer closed this Sep 21, 2018
@exalted exalted deleted the patch-1 branch October 10, 2018 14:44
@exalted
Copy link
Author

exalted commented Oct 10, 2018

Thanks.

@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants