New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add environment variable to optionaly disable inlining of chunks #5354

Merged
merged 5 commits into from Oct 8, 2018

Conversation

Projects
None yet
4 participants
@0xdeafcafe
Contributor

0xdeafcafe commented Oct 8, 2018

Adds the environment variable INLINE_CHUNK, which when set to false will disable the automatic inlining of the runtime chunk into the outputted index.html file.

As per discussion in #5309.

@facebook-github-bot

This comment has been minimized.

facebook-github-bot commented Oct 8, 2018

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@Timer Timer added this to the 2.0.5 milestone Oct 8, 2018

@facebook-github-bot

This comment has been minimized.

facebook-github-bot commented Oct 8, 2018

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@gaearon

This comment has been minimized.

Member

gaearon commented Oct 8, 2018

Let's call it INLINE_RUNTIME_CHUNK.

@Timer

This comment has been minimized.

Collaborator

Timer commented Oct 8, 2018

Also, please add this to the Advanced Configuration section in the documentation (User Guide).

0xdeafcafe added some commits Oct 8, 2018

@facebook-github-bot

This comment has been minimized.

facebook-github-bot commented Oct 8, 2018

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@0xdeafcafe

This comment has been minimized.

Contributor

0xdeafcafe commented Oct 8, 2018

Done and done. Let me know if the docs aren't correct, the emoji's for dev/prod were a little confusing. I assume a cross means it doesn't get listened to in that environment, and a tick means it does?

Timer added some commits Oct 8, 2018

@Timer Timer merged commit 9971653 into facebook:master Oct 8, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@Timer

This comment has been minimized.

Collaborator

Timer commented Oct 8, 2018

Thanks, you got it!

zhDmitry pushed a commit to zhDmitry/create-react-app that referenced this pull request Oct 29, 2018

Add environment variable to optionaly disable inlining of chunks (fac…
…ebook#5354)

* Add environment variable to optionaly disable inlining of chunks

* Changed env var to `process.env.INLINE_RUNTIME_CHUNK `

* Added env var to Advanced Configuration in docs

* Drop implied behavior

* Tweak working to match other descriptions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment