Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to clarify the "waiting" SW behavior #5410

Merged
merged 1 commit into from Oct 12, 2018

Conversation

Projects
None yet
3 participants
@jeffposnick
Copy link
Contributor

commented Oct 11, 2018

R: @Timer

This includes updates to both the SW registration JS file (comments and console.log() messages) and the "Offline-first Considerations" section of the README, in the hopes of clarifying the current implications of the service worker lifecycle for users who decide to opt-in to service workers.

@facebook-github-bot

This comment has been minimized.

Copy link

commented Oct 11, 2018

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@Timer Timer merged commit 5060768 into facebook:master Oct 12, 2018

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Timer Timer added this to the 2.0.5 milestone Oct 12, 2018

@jeffposnick jeffposnick deleted the jeffposnick:waiting-sw-clarification branch Oct 23, 2018

zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Oct 29, 2018

@lock lock bot locked and limited conversation to collaborators Jan 18, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.