Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update making-a-progressive-web-app.md #5658

Merged
merged 1 commit into from Nov 1, 2018

Conversation

@jakeboone02
Copy link
Contributor

commented Oct 31, 2018

Small grammar correction in the documentation.

@Timer Timer added this to the 2.1.1 milestone Nov 1, 2018

@Timer Timer merged commit c11cc81 into facebook:master Nov 1, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Timer

This comment has been minimized.

Copy link
Collaborator

commented Nov 1, 2018

Thanks!

@jakeboone02 jakeboone02 deleted the jakeboone02:patch-1 branch Nov 1, 2018

danielmahon added a commit to danielmahon/create-react-app that referenced this pull request Nov 2, 2018
@seanlmcgill

This comment has been minimized.

Copy link

commented Nov 6, 2018

Still have a grammatical mistake:

these messages is currently left as

Should be: 'are' ;)

@jakeboone02

This comment has been minimized.

Copy link
Contributor Author

commented Nov 6, 2018

@seanlmcgill I almost fell for that, too, but check again. "Showing these messages" is singular, as in "Showing [...] is." The object of the "is" verb is not "messages" but "showing."

@lock lock bot locked and limited conversation to collaborators Jan 18, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.