Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add empty mock for http2 #5686

Merged
merged 1 commit into from Mar 14, 2019

Conversation

@kjin
Copy link
Contributor

commented Nov 2, 2018

Following suit with #2600, this PR adds http2 as an empty module in webpack configs. I don't see http to the list, which suggests that this empty mock should probably be replaced with a browser-side implementation sometime in the future (I can add a TODO if needed).

See: grpc/grpc-node#610 (Even though it turns out the module in question seems to not be meant for the client side, I believe the lack of this mock masked the real issue)

@facebook-github-bot

This comment has been minimized.

Copy link

commented Nov 2, 2018

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@kjin kjin referenced this pull request Nov 2, 2018

Open

Module 'http2' not found #610

@kjin kjin closed this Nov 8, 2018

@rwieruch

This comment has been minimized.

Copy link

commented Nov 29, 2018

@kjin what happened to this PR? I stumbled across the same issue with firebase-admin.

@kjin

This comment has been minimized.

Copy link
Contributor Author

commented Nov 29, 2018

At the time I wasn't sure if this would just be papering over a bigger problem. Though, it might still be good to get this in first, so that the real problem (that google-gax depends transitively on http2, even if it doesn't get compiled into the app itself) can get fixed downstream.

@kjin kjin reopened this Nov 29, 2018

@kjin kjin force-pushed the kjin:h2 branch from 52de492 to 1bfebf2 Nov 29, 2018

@iansu

This comment has been minimized.

Copy link
Collaborator

commented Nov 29, 2018

I think you will need to email cla@fb.com then.

@kjin

This comment has been minimized.

Copy link
Contributor Author

commented Nov 29, 2018

@iansu I'll re-open a new PR, since it seems like the CLA signed label will get applied automatically (but maybe not to ones that were once closed?)

Edit: jk, it's there

@facebook-github-bot

This comment has been minimized.

Copy link

commented Nov 29, 2018

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@kjin kjin reopened this Nov 29, 2018

@iansu

This comment has been minimized.

Copy link
Collaborator

commented Nov 29, 2018

Looks like that worked.

@stale

This comment has been minimized.

Copy link

commented Dec 30, 2018

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Dec 30, 2018

@iansu iansu removed the stale label Dec 30, 2018

@kjin

This comment has been minimized.

Copy link
Contributor Author

commented Jan 2, 2019

@iansu anything I need to do to advance the state of this PR? Thanks!

@fletcherist

This comment has been minimized.

Copy link

commented Jan 5, 2019

Hi, want this feature to be merged very much!

@kjin

This comment has been minimized.

Copy link
Contributor Author

commented Jan 7, 2019

ping @iansu

@zeeshancb

This comment has been minimized.

Copy link

commented Jan 9, 2019

@kjin is there temporary fix to solve this issue?

@Timer Timer closed this Jan 9, 2019

@Timer Timer reopened this Jan 9, 2019

@kjin

This comment has been minimized.

Copy link
Contributor Author

commented Jan 9, 2019

@zeeshancb This is probably as "temporary" as it gets, it papers over a problem that really lies in the usage of certain modules -- as HTTP2 is not implemented in the browser, if you're using a module that depends on it, either (a) you should not be using it or (b) the module authors themselves should be taking steps to making their module web-compatible, whether that means conditionally requiring http2 or something more involved.

@Timer

This comment has been minimized.

Copy link
Collaborator

commented Jan 9, 2019

Looks like this broke CI.

@kjin kjin force-pushed the kjin:h2 branch from 1bfebf2 to af0301e Jan 9, 2019

@iansu

This comment has been minimized.

Copy link
Collaborator

commented Jan 10, 2019

I think the test failures are unrelated. Seeing the same error on some other PRs.

@stale

This comment has been minimized.

Copy link

commented Feb 9, 2019

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Feb 9, 2019

@Timer Timer closed this Feb 10, 2019

@Timer Timer reopened this Feb 10, 2019

@stale stale bot removed the stale label Feb 10, 2019

@kjin kjin force-pushed the kjin:h2 branch from af0301e to 6c9053b Feb 11, 2019

@stale

This comment has been minimized.

Copy link

commented Mar 13, 2019

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Mar 13, 2019

@iansu iansu closed this Mar 14, 2019

@iansu iansu reopened this Mar 14, 2019

@stale stale bot removed the stale label Mar 14, 2019

@iansu iansu added this to the 3.0 milestone Mar 14, 2019

@iansu iansu added this to In progress in v3 via automation Mar 14, 2019

@iansu iansu merged commit 88d6f02 into facebook:master Mar 14, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
netlify/create-react-app/deploy-preview Docs deploy preview succeeded
Details

v3 automation moved this from In progress to Done Mar 14, 2019

@iansu

This comment has been minimized.

Copy link
Collaborator

commented Mar 14, 2019

Thanks!

JoviDeCroock added a commit to JoviDeCroock/create-react-app that referenced this pull request Mar 15, 2019

Merge branch 'masterd' into feat/modern-build
* masterd: (24 commits)
  Add TypeScript linting support (facebook#6513)
  Support React Hooks (facebook#5602) (facebook#5997)
  Support browserslist in @babel/preset-env (facebook#6608)
  Add empty mock for http2 (facebook#5686)
  Add note about npx caching (facebook#6374)
  change named import into default import (facebook#6625)
  Stage files for commit after ejecting (facebook#5960)
  Upgrade dependencies (facebook#6614)
  Make compiler variable const instead of let (facebook#6621)
  Type check JSON files (facebook#6615)
  Change class components to functional components in templates (facebook#6451)
  Convert JSON.stringify \n to os.EOL when writing tsconfig.json (facebook#6610)
  Update html-webpack-plugin (facebook#6361)
  Enable click to go to error in console for TypeScript (facebook#6502)
  Update webpack-dev-server to 3.2.1 (facebook#6483)
  [docs] revert removal of newlines from html (facebook#6386)
  Publish
  Prepare 2.1.8 release
  Reapply "Speed up TypeScript v2 (facebook#6406)" (facebook#6586)
  Publish
  ...

# Conflicts:
#	packages/babel-preset-react-app/create.js
#	packages/react-scripts/scripts/build.js

@lock lock bot locked and limited conversation to collaborators Mar 19, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
7 participants
You can’t perform that action at this time.