Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Simplify installing Storybook with npx #5788

Merged
merged 1 commit into from Nov 14, 2018

Conversation

@sagirk
Copy link
Contributor

commented Nov 13, 2018

Reduce the two-step install process to just one (per the latest storybook docs)

Change (i) npm install -g @storybook/cli and (ii) sb init to npx -p @storybook/cli sb init

Old commands New command
(i) npm install -g @storybook/cli npx -p @storybook/cli sb init
(ii) sb init

Refs: https://storybook.js.org/basics/quick-start-guide/

docs: Simplify installing Storybook with npx
Reduce two-step install to just one step (per the latest storybook docs)

Change (i) `npm install -g @storybook/cli` and (ii) `sb init` to `npx -p @storybook/cli sb init`

Refs: https://storybook.js.org/basics/quick-start-guide/
@facebook-github-bot

This comment has been minimized.

Copy link

commented Nov 13, 2018

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot

This comment has been minimized.

Copy link

commented Nov 13, 2018

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@sagirk

This comment has been minimized.

Copy link
Contributor Author

commented Nov 14, 2018

Build failure seems to be unrelated. I'm happy to make changes if that is not the case.

@iansu iansu added this to the 2.1.2 milestone Nov 14, 2018

@iansu iansu merged commit d72256c into facebook:master Nov 14, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@iansu

This comment has been minimized.

Copy link
Collaborator

commented Nov 14, 2018

Thanks!

kulek1 added a commit to kulek1/create-react-app that referenced this pull request Nov 14, 2018
docs: Simplify installing Storybook with npx (facebook#5788)
Reduce two-step install to just one step (per the latest storybook docs)

Change (i) `npm install -g @storybook/cli` and (ii) `sb init` to `npx -p @storybook/cli sb init`

Refs: https://storybook.js.org/basics/quick-start-guide/

@sagirk sagirk deleted the sagirk:patch-1 branch Nov 15, 2018

dardub added a commit to OffBase/create-react-app that referenced this pull request Nov 27, 2018
Merge remote-tracking branch 'upstream/master'
* upstream/master: (210 commits)
  Support setupTests.ts (facebook#5698)
  Remove unnecessary whitespace in template HTML
  Run prettier on HTML files (facebook#5839)
  Some Grammar fixes (facebook#5858)
  Fix link to page about running tests (facebook#5883)
  fix: make typescriptformatter support 0.5 of fork checker (facebook#5879)
  Always test with the latest stable Node version on Travis (facebook#5546)
  Fix propertyDecorator test
  Upgrade babel deps
  Fix annotated var test
  Fix TypeScript decorator support (facebook#5783)
  fix: add `sideEffects: false` to react-error-overlay (facebook#5451)
  Add allowESModules option to babel-preset-react-app (facebook#5487)
  Make named-asset-import plugin work with export-as syntax (facebook#5573)
  React native repository updated in README.md (facebook#5849)
  extra polyfills must be included manually (facebook#5814)
  Rename 'getting started' link to 'docs' (facebook#5806)
  docs: Simplify installing Storybook with npx (facebook#5788)
  Don't polyfill fetch for Node -- additional files (facebook#5789)
  docs: Change Storybook install documentation (facebook#5779)
  ...

@lock lock bot locked and limited conversation to collaborators Jan 18, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.