Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Add wait: false to options object for opn #5821
As far as I can see, there is no downside to adding
Testing on Ubuntu before the change:
This fixes #3113 for me on Ubuntu and causes no regressions on macOS Mojave (where I was unable to replicate the issue due to it not using
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.
If you have received this in error or have any questions, please contact us at email@example.com. Thanks!
Feb 22, 2019
requested review from
Feb 22, 2019
@mrmckeb I've recorded some examples where I run a quick script:
#!/bin/bash -e echo -e "Ubuntu version $(head -n2 /etc/os-release)\\n" echo -e "Chrome version: $(google-chrome-unstable --version)\\n" echo -e "Yarn version: $(yarn --version)\\n" echo -e "Value of options: $(sed -n 99p test-app/node_modules/react-dev-utils/openBrowser.js)\\n"
(I now realise after recording I forgot to check
As you can see in the old behaviour (Pre-PR behaviour with browser closed), without
Hope this answers your query!
I've tested both starting from no browser open and starting with the browser already open on: