Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explanation for adding everything as dependencies to docs #6082

Merged
merged 4 commits into from Apr 3, 2019

Conversation

@mikeattara
Copy link
Contributor

commented Dec 22, 2018

add the reason for adding packages as dependencies

Update available-scripts.md
add the reason for adding packages as dependencies

@mikeattara mikeattara changed the title Add reason for adding everything as dependencies to docs #5885 Add reason for adding everything as dependencies to docs Dec 22, 2018

@mikeattara

This comment has been minimized.

Copy link
Contributor Author

commented Dec 22, 2018

@iansu what do you think?

@mikeattara mikeattara changed the title Add reason for adding everything as dependencies to docs Add explanation for adding everything as dependencies to docs Dec 22, 2018

@mikeattara

This comment has been minimized.

Copy link
Contributor Author

commented Dec 23, 2018

@Timer what is your thought?

@ianschmitz ianschmitz added this to the 2.1.4 milestone Jan 7, 2019

@ianschmitz ianschmitz modified the milestones: 2.1.4, 2.1.5 Feb 10, 2019

@iansu iansu modified the milestones: 2.1.6, 2.1.x Mar 6, 2019

@mikeattara

This comment has been minimized.

Copy link
Contributor Author

commented Mar 6, 2019

@ianschmitz what is your thought?

@iansu iansu modified the milestones: 2.1.x, 3.0 Mar 10, 2019

@iansu iansu added this to In progress in v3 Mar 10, 2019

@amyrlam amyrlam force-pushed the facebook:master branch from cecd762 to d3b19f9 Mar 24, 2019

@amyrlam amyrlam requested review from amyrlam and iansu as code owners Apr 3, 2019

@amyrlam

amyrlam approved these changes Apr 3, 2019

Copy link
Collaborator

left a comment

Made a small tweak, looks good, thanks for the PR! 👍

Show resolved Hide resolved docusaurus/docs/available-scripts.md Outdated
Show resolved Hide resolved docusaurus/docs/available-scripts.md Outdated
Show resolved Hide resolved docusaurus/docs/available-scripts.md Outdated

@amyrlam amyrlam requested a review from iansu Apr 3, 2019

@iansu iansu merged commit e630238 into facebook:master Apr 3, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
netlify/create-react-app/deploy-preview Docs deploy preview succeeded
Details

v3 automation moved this from In progress to Done Apr 3, 2019

@lock lock bot locked and limited conversation to collaborators Apr 8, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
5 participants
You can’t perform that action at this time.