Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deployment instructions with AWS Amplify #6208

Merged
merged 7 commits into from Mar 21, 2019

Conversation

@swaminator
Copy link
Contributor

commented Jan 15, 2019

Added instructions on how to deploy a CRA app with AWS Amplify.

swaminator added some commits Jan 15, 2019

@facebook-github-bot

This comment has been minimized.

Copy link

commented Jan 15, 2019

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot

This comment has been minimized.

Copy link

commented Jan 24, 2019

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@swaminator

This comment has been minimized.

Copy link
Contributor Author

commented Jan 24, 2019

Hi - now that the CLA has been signed, would appreciate feedback on this PR. Thanks!

@swaminator

This comment has been minimized.

Copy link
Contributor Author

commented Jan 29, 2019

@npverni @saimonmoore Please review this PR and let me know if it can be merged. Thanks!

@swaminator

This comment has been minimized.

Copy link
Contributor Author

commented Feb 1, 2019

Following up again with more folks @mg. Can we please review this PR? Thanks.

@mg

This comment has been minimized.

Copy link
Contributor

commented Feb 1, 2019

I don't understand why I am being included in this, surely you mean to tag someone else?

@swaminator

This comment has been minimized.

Copy link
Contributor Author

commented Feb 2, 2019

Apologies for the tag (you showed up when I typed out the message in the editor box). I'm looking for someone to review my PR so it can get merged. Haven't had too much luck getting anyone to respond in the past week.

@stale

This comment has been minimized.

Copy link

commented Mar 4, 2019

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Mar 4, 2019

@iansu iansu removed the stale label Mar 4, 2019

@iansu iansu self-assigned this Mar 4, 2019

@iansu iansu requested a review from amyrlam Mar 4, 2019

@swaminator

This comment has been minimized.

Copy link
Contributor Author

commented Mar 8, 2019

Hi @iansu, I'd love for this PR to be reviewed and accepted.

@swaminator

This comment has been minimized.

Copy link
Contributor Author

commented Mar 18, 2019

@amyrlam Can you please review this PR? It's been 2 months.

Show resolved Hide resolved docusaurus/docs/deployment.md Outdated
Show resolved Hide resolved docusaurus/docs/deployment.md Outdated
Show resolved Hide resolved docusaurus/docs/deployment.md Outdated

iansu and others added some commits Mar 20, 2019

Update docusaurus/docs/deployment.md
create-react-app to Create React App

Co-Authored-By: swaminator <nikhil@live.ca>
Update docusaurus/docs/deployment.md
Removed extra verbiage.

Co-Authored-By: swaminator <nikhil@live.ca>
@swaminator

This comment has been minimized.

Copy link
Contributor Author

commented Mar 20, 2019

@iansu all requested changes are made.

@iansu iansu added this to In progress in v3 via automation Mar 21, 2019

@iansu iansu added this to the 3.0 milestone Mar 21, 2019

@iansu iansu merged commit 5c637a4 into facebook:master Mar 21, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
netlify/create-react-app/deploy-preview Docs deploy preview succeeded
Details

v3 automation moved this from In progress to Done Mar 21, 2019

@iansu

This comment has been minimized.

Copy link
Collaborator

commented Mar 21, 2019

Looks good. Thanks!

@swaminator

This comment has been minimized.

Copy link
Contributor Author

commented Mar 21, 2019

Thanks @iansu. I just visited the webpage and don't see the docs yet. Is there a delay for propagation?

@iansu

This comment has been minimized.

Copy link
Collaborator

commented Mar 21, 2019

Yes, we generally only publish the docs after each release.

@lock lock bot locked and limited conversation to collaborators Mar 26, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
4 participants
You can’t perform that action at this time.