Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove body padding reset from templates #6300

Merged
merged 2 commits into from Apr 24, 2019

Conversation

@Hurtak
Copy link
Contributor

commented Jan 29, 2019

AFAIK reseting padding is useless since there is no padding on body in browser default styles
https://www.w3schools.com/cssref/css_default_values.asp

@stale

This comment has been minimized.

Copy link

commented Feb 28, 2019

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Feb 28, 2019

@Hurtak Hurtak closed this Feb 28, 2019

@Hurtak Hurtak force-pushed the Hurtak:patch-2 branch from 019650e to ff19e0a Feb 28, 2019

@Hurtak Hurtak reopened this Feb 28, 2019

@stale stale bot removed stale labels Feb 28, 2019

@Hurtak Hurtak force-pushed the Hurtak:patch-2 branch from bd3ca26 to 436b7a1 Feb 28, 2019

@amyrlam amyrlam force-pushed the facebook:master branch from cecd762 to d3b19f9 Mar 24, 2019

@stale

This comment has been minimized.

Copy link

commented Apr 23, 2019

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Apr 23, 2019

@Hurtak

This comment has been minimized.

Copy link
Contributor Author

commented Apr 24, 2019

Ping

@stale stale bot removed the stale label Apr 24, 2019

@mrmckeb

This comment has been minimized.

Copy link
Collaborator

commented Apr 24, 2019

Hi @Hurtak, you're correct and I've confirmed with some independent research. I've also noted that this is not included in normalize.css.

@mrmckeb mrmckeb changed the title remove padding 0 on body from default styles Remove body padding reset from templates Apr 24, 2019

@iansu iansu added this to the 3.0.1 milestone Apr 24, 2019

@iansu iansu merged commit 73d5579 into facebook:master Apr 24, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
netlify/create-react-app/deploy-preview Docs deploy preview succeeded
Details
@iansu

This comment has been minimized.

Copy link
Collaborator

commented Apr 24, 2019

Thanks!

@Hurtak Hurtak deleted the Hurtak:patch-2 branch Apr 25, 2019

@lock lock bot locked and limited conversation to collaborators Apr 30, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.