Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update advanced-configuration.md #6491

Merged
merged 2 commits into from Mar 26, 2019

Conversation

@stephengodderidge
Copy link
Contributor

commented Feb 22, 2019

No description provided.

@stephengodderidge stephengodderidge requested review from amyrlam and iansu as code owners Feb 22, 2019

@facebook-github-bot

This comment has been minimized.

Copy link

commented Feb 22, 2019

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot

This comment has been minimized.

Copy link

commented Feb 22, 2019

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@Ritzing

Ritzing approved these changes Mar 7, 2019

@amyrlam amyrlam force-pushed the facebook:master branch from cecd762 to d3b19f9 Mar 24, 2019

@amyrlam amyrlam self-assigned this Mar 24, 2019

You can adjust various development and production settings by setting environment variables in your shell or with [.env](adding-custom-environment-variables.md#adding-development-environment-variables-in-env).
You can adjust various development and production settings by setting environment variables in your shell or with [.env](adding-custom-environment-variables.md#adding-development-environment-variables-in-env).

> Note: You do not need to declare `REACT_APP_` before the below variables as you would with custom environment variables

This comment has been minimized.

Copy link
@amyrlam

amyrlam Mar 26, 2019

Collaborator
Suggested change
> Note: You do not need to declare `REACT_APP_` before the below variables as you would with custom environment variables
> Note: You do not need to declare `REACT_APP_` before the below variables as you would with custom environment variables.

This comment has been minimized.

Copy link
@amyrlam

amyrlam Mar 26, 2019

Collaborator

just committed instead

@amyrlam
Copy link
Collaborator

left a comment

Thanks for the PR, looks good 👍

@amyrlam amyrlam merged commit fb6851d into facebook:master Mar 26, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
netlify/create-react-app/deploy-preview Docs deploy preview succeeded
Details

@amyrlam amyrlam added this to the 3.0 milestone Mar 26, 2019

@lock lock bot locked and limited conversation to collaborators Mar 31, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.