Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix react-scripts peer-deps link local issue #6580

Merged

Conversation

@transitive-bullshit
Copy link
Contributor

commented Mar 5, 2019

Fixes #6579.

Discussion of issue and repro steps in linked issue.

@iansu iansu self-assigned this Mar 6, 2019

@amyrlam amyrlam force-pushed the facebook:master branch from cecd762 to d3b19f9 Mar 24, 2019

@iansu iansu added this to In progress in v3 via automation Apr 5, 2019

@iansu iansu added this to the 3.0 milestone Apr 5, 2019

@iansu iansu added the tag: internal label Apr 5, 2019

@ianschmitz ianschmitz changed the title Fix react-scripts peer-deps link local issue (#6579) Fix react-scripts peer-deps link local issue Apr 7, 2019

@ianschmitz ianschmitz closed this Apr 7, 2019

v3 automation moved this from In progress to Done Apr 7, 2019

@ianschmitz ianschmitz reopened this Apr 7, 2019

v3 automation moved this from Done to In progress Apr 7, 2019

@iansu

This comment has been minimized.

Copy link
Collaborator

commented Apr 16, 2019

I think this should be fine. I'm going to merge it and release it in the next 3.0 alpha so we can get some people to try it out.

@iansu iansu merged commit 50c1884 into facebook:master Apr 16, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
netlify/create-react-app/deploy-preview Docs deploy preview succeeded
Details

v3 automation moved this from In progress to Done Apr 16, 2019

@lock lock bot locked and limited conversation to collaborators Apr 21, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.