Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support browserslist in @babel/preset-env #6608

Merged
merged 7 commits into from Mar 14, 2019

Conversation

@ianschmitz
Copy link
Collaborator

commented Mar 9, 2019

This PR brings back support for configuring the build output based on browserslist, as well as supporting @babel/polyfill in the entrypoint. This provides a huge improvement to the dev experience as it allows targeting modern browsers in development which makes certain language features like async/await much nicer to debug, while still supporting a broad range of browsers in production.

Including ie 9 in browserslist:
image

Modern browsers:
image

Closes #6198.

@ianschmitz ianschmitz added this to the 3.0 milestone Mar 9, 2019

@ianschmitz ianschmitz changed the title Presetenv browserslist Support browserslist in @babel/preset-env Mar 9, 2019

docusaurus/docs/supported-browsers-features.md Outdated Show resolved Hide resolved
docusaurus/docs/supported-browsers-features.md Outdated Show resolved Hide resolved

@iansu iansu added this to In progress in v3 Mar 10, 2019

iansu and others added some commits Mar 10, 2019

Update docusaurus/docs/supported-browsers-features.md
Co-Authored-By: ianschmitz <ianschmitz@gmail.com>
Update docusaurus/docs/supported-browsers-features.md
Co-Authored-By: ianschmitz <ianschmitz@gmail.com>
@iansu iansu referenced this pull request Mar 10, 2019

@ianschmitz ianschmitz merged commit f4f20a2 into facebook:master Mar 14, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
netlify/create-react-app/deploy-preview Docs deploy preview succeeded
Details

v3 automation moved this from In progress to Done Mar 14, 2019

@ianschmitz ianschmitz deleted the ianschmitz:presetenv-browserslist branch Mar 14, 2019

JoviDeCroock added a commit to JoviDeCroock/create-react-app that referenced this pull request Mar 15, 2019

Merge branch 'masterd' into feat/modern-build
* masterd: (24 commits)
  Add TypeScript linting support (facebook#6513)
  Support React Hooks (facebook#5602) (facebook#5997)
  Support browserslist in @babel/preset-env (facebook#6608)
  Add empty mock for http2 (facebook#5686)
  Add note about npx caching (facebook#6374)
  change named import into default import (facebook#6625)
  Stage files for commit after ejecting (facebook#5960)
  Upgrade dependencies (facebook#6614)
  Make compiler variable const instead of let (facebook#6621)
  Type check JSON files (facebook#6615)
  Change class components to functional components in templates (facebook#6451)
  Convert JSON.stringify \n to os.EOL when writing tsconfig.json (facebook#6610)
  Update html-webpack-plugin (facebook#6361)
  Enable click to go to error in console for TypeScript (facebook#6502)
  Update webpack-dev-server to 3.2.1 (facebook#6483)
  [docs] revert removal of newlines from html (facebook#6386)
  Publish
  Prepare 2.1.8 release
  Reapply "Speed up TypeScript v2 (facebook#6406)" (facebook#6586)
  Publish
  ...

# Conflicts:
#	packages/babel-preset-react-app/create.js
#	packages/react-scripts/scripts/build.js

@lock lock bot locked and limited conversation to collaborators Mar 19, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
3 participants
You can’t perform that action at this time.