Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies #6614

Merged
merged 3 commits into from Mar 12, 2019

Conversation

@ianschmitz
Copy link
Collaborator

commented Mar 10, 2019

Upgrades a bunch of our dependencies

@ianschmitz ianschmitz added this to the 3.0 milestone Mar 10, 2019

@ianschmitz ianschmitz added this to In progress in v3 via automation Mar 10, 2019

@ianschmitz ianschmitz referenced this pull request Mar 10, 2019

Closed

Upgrade dependencies #5361

@iansu

This comment has been minimized.

Copy link
Collaborator

commented Mar 11, 2019

A couple of questions:

  1. Have you verified that none of the major version upgrades introduce any breaking changes?
  2. I see some dependencies with ^ and ~. In general we try to pin everything. Is there a reason some aren't pinned?
  3. Upgrading prettier can introduce formatting changes. Have you tried running it on the entire codebase to see what effect it will have?
@ianschmitz

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 11, 2019

A couple of questions:

  1. Have you verified that none of the major version upgrades introduce any breaking changes?
  2. I see some dependencies with ^ and ~. In general we try to pin everything. Is there a reason some aren't pinned?
  3. Upgrading prettier can introduce formatting changes. Have you tried running it on the entire codebase to see what effect it will have?
  1. Yes i reviewed the changes for each package that changed majors. You'll see i edited a couple source files to reflect these changes.
  2. I kept the pinning the same in all cases except for 2. husky is now carat like most other deps as it's stable and is a dev dependency. lerna-changelog was previously a ^ but really should have been ~ since it's pre 1.0 and have breaking changes between minors
  3. Only one file changed and has been committed.

@iansu iansu merged commit 3c9c21a into facebook:master Mar 12, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
netlify/create-react-app/deploy-preview Docs deploy preview succeeded
Details

v3 automation moved this from In progress to Done Mar 12, 2019

@ianschmitz ianschmitz deleted the ianschmitz:upgrade-deps branch Mar 12, 2019

@iansu iansu referenced this pull request Mar 13, 2019

Closed

Update eslint-plugin-import #6396

JoviDeCroock added a commit to JoviDeCroock/create-react-app that referenced this pull request Mar 15, 2019

Merge branch 'masterd' into feat/modern-build
* masterd: (24 commits)
  Add TypeScript linting support (facebook#6513)
  Support React Hooks (facebook#5602) (facebook#5997)
  Support browserslist in @babel/preset-env (facebook#6608)
  Add empty mock for http2 (facebook#5686)
  Add note about npx caching (facebook#6374)
  change named import into default import (facebook#6625)
  Stage files for commit after ejecting (facebook#5960)
  Upgrade dependencies (facebook#6614)
  Make compiler variable const instead of let (facebook#6621)
  Type check JSON files (facebook#6615)
  Change class components to functional components in templates (facebook#6451)
  Convert JSON.stringify \n to os.EOL when writing tsconfig.json (facebook#6610)
  Update html-webpack-plugin (facebook#6361)
  Enable click to go to error in console for TypeScript (facebook#6502)
  Update webpack-dev-server to 3.2.1 (facebook#6483)
  [docs] revert removal of newlines from html (facebook#6386)
  Publish
  Prepare 2.1.8 release
  Reapply "Speed up TypeScript v2 (facebook#6406)" (facebook#6586)
  Publish
  ...

# Conflicts:
#	packages/babel-preset-react-app/create.js
#	packages/react-scripts/scripts/build.js

@lock lock bot locked and limited conversation to collaborators Mar 17, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.