Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow .json type checking #6615

Merged
merged 1 commit into from Mar 11, 2019

Conversation

@ianschmitz
Copy link
Collaborator

commented Mar 10, 2019

Closes #5619.

This adds back support for type checking of .json files. We had to disable previously due to a bug in TypeScript which was fixed a while back.

Here is an example:
image

@ianschmitz ianschmitz added this to the 3.0 milestone Mar 10, 2019

@ianschmitz ianschmitz added this to In progress in v3 via automation Mar 10, 2019

@iansu iansu closed this Mar 11, 2019

v3 automation moved this from In progress to Done Mar 11, 2019

@iansu iansu reopened this Mar 11, 2019

v3 automation moved this from Done to In progress Mar 11, 2019

@iansu iansu merged commit 1a04b96 into facebook:master Mar 11, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
netlify/create-react-app/deploy-preview Docs deploy preview succeeded
Details

v3 automation moved this from In progress to Done Mar 11, 2019

@iansu

This comment has been minimized.

Copy link
Collaborator

commented Mar 11, 2019

Thanks!

@ianschmitz ianschmitz deleted the ianschmitz:typecheck-json branch Mar 11, 2019

JoviDeCroock added a commit to JoviDeCroock/create-react-app that referenced this pull request Mar 15, 2019

Merge branch 'masterd' into feat/modern-build
* masterd: (24 commits)
  Add TypeScript linting support (facebook#6513)
  Support React Hooks (facebook#5602) (facebook#5997)
  Support browserslist in @babel/preset-env (facebook#6608)
  Add empty mock for http2 (facebook#5686)
  Add note about npx caching (facebook#6374)
  change named import into default import (facebook#6625)
  Stage files for commit after ejecting (facebook#5960)
  Upgrade dependencies (facebook#6614)
  Make compiler variable const instead of let (facebook#6621)
  Type check JSON files (facebook#6615)
  Change class components to functional components in templates (facebook#6451)
  Convert JSON.stringify \n to os.EOL when writing tsconfig.json (facebook#6610)
  Update html-webpack-plugin (facebook#6361)
  Enable click to go to error in console for TypeScript (facebook#6502)
  Update webpack-dev-server to 3.2.1 (facebook#6483)
  [docs] revert removal of newlines from html (facebook#6386)
  Publish
  Prepare 2.1.8 release
  Reapply "Speed up TypeScript v2 (facebook#6406)" (facebook#6586)
  Publish
  ...

# Conflicts:
#	packages/babel-preset-react-app/create.js
#	packages/react-scripts/scripts/build.js

@lock lock bot locked and limited conversation to collaborators Mar 16, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
3 participants
You can’t perform that action at this time.