Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change app component declaration from arrow function to regular function #6655

Merged
merged 2 commits into from Mar 19, 2019

Conversation

@iansu
Copy link
Collaborator

iansu commented Mar 15, 2019

Small update to the default templates to keep them consistent with the React docs.

@iansu iansu added this to In progress in v3 via automation Mar 15, 2019

@iansu iansu added this to the 3.0 milestone Mar 15, 2019

@amshtemp

This comment has been minimized.

Copy link

amshtemp commented Mar 17, 2019

@iansu
function App(): React.FC { }
vs.
const App: React.FC = () => {}

aren't those different (return type vs function type)?

@iansu

This comment has been minimized.

Copy link
Collaborator Author

iansu commented Mar 17, 2019

@amshtemp Yes they are different. We're probably going to change the TypeScript template back to an arrow function.

@petetnt
Copy link
Collaborator

petetnt left a comment

LGTM

@iansu iansu merged commit b424737 into facebook:master Mar 19, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
netlify/create-react-app/deploy-preview Docs deploy preview succeeded
Details

v3 automation moved this from In progress to Done Mar 19, 2019

@lock lock bot locked and limited conversation to collaborators Mar 24, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.